drm: Don't implement empty prepare_fb()/cleanup_fb()
The plane .prepare_fb() and .cleanup_fb() helpers are optional, there's no need to implement empty stubs, and no need to explicitly set the function pointers to NULL either. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> [danvet: Resolved conflicts with Chris' patch.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:

کامیت شده توسط
Daniel Vetter

والد
7ad61e6b4a
کامیت
420382adf6
@@ -480,17 +480,6 @@ static const struct drm_plane_funcs tegra_primary_plane_funcs = {
|
||||
.atomic_destroy_state = tegra_plane_atomic_destroy_state,
|
||||
};
|
||||
|
||||
static int tegra_plane_prepare_fb(struct drm_plane *plane,
|
||||
struct drm_plane_state *new_state)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void tegra_plane_cleanup_fb(struct drm_plane *plane,
|
||||
struct drm_plane_state *old_fb)
|
||||
{
|
||||
}
|
||||
|
||||
static int tegra_plane_state_add(struct tegra_plane *plane,
|
||||
struct drm_plane_state *state)
|
||||
{
|
||||
@@ -624,8 +613,6 @@ static void tegra_plane_atomic_disable(struct drm_plane *plane,
|
||||
}
|
||||
|
||||
static const struct drm_plane_helper_funcs tegra_primary_plane_helper_funcs = {
|
||||
.prepare_fb = tegra_plane_prepare_fb,
|
||||
.cleanup_fb = tegra_plane_cleanup_fb,
|
||||
.atomic_check = tegra_plane_atomic_check,
|
||||
.atomic_update = tegra_plane_atomic_update,
|
||||
.atomic_disable = tegra_plane_atomic_disable,
|
||||
@@ -796,8 +783,6 @@ static const struct drm_plane_funcs tegra_cursor_plane_funcs = {
|
||||
};
|
||||
|
||||
static const struct drm_plane_helper_funcs tegra_cursor_plane_helper_funcs = {
|
||||
.prepare_fb = tegra_plane_prepare_fb,
|
||||
.cleanup_fb = tegra_plane_cleanup_fb,
|
||||
.atomic_check = tegra_cursor_atomic_check,
|
||||
.atomic_update = tegra_cursor_atomic_update,
|
||||
.atomic_disable = tegra_cursor_atomic_disable,
|
||||
@@ -866,8 +851,6 @@ static const uint32_t tegra_overlay_plane_formats[] = {
|
||||
};
|
||||
|
||||
static const struct drm_plane_helper_funcs tegra_overlay_plane_helper_funcs = {
|
||||
.prepare_fb = tegra_plane_prepare_fb,
|
||||
.cleanup_fb = tegra_plane_cleanup_fb,
|
||||
.atomic_check = tegra_plane_atomic_check,
|
||||
.atomic_update = tegra_plane_atomic_update,
|
||||
.atomic_disable = tegra_plane_atomic_disable,
|
||||
|
مرجع در شماره جدید
Block a user