xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bridge: use struct_size() helper

Browse Source 
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = alloc(size, GFP_KERNEL)

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

size = struct_size(instance, entry, count);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva
2019-02-07 18:58:56 -06:00
committed by David S. Miller
parent 6f0282bfe3
commit 4154b567b6
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
net/bridge/br_multicast.c
View File

@@ -1018,8 +1018,7 @@ static int br_ip6_multicast_mld2_report(struct net_bridge *br,
if (!nsrcs) if (!nsrcs)
return -EINVAL; return -EINVAL;
grec_len = sizeof(*grec) + grec_len = struct_size(grec, grec_src, ntohs(*nsrcs));
sizeof(struct in6_addr) * ntohs(*nsrcs);
if (!ipv6_mc_may_pull(skb, len + grec_len)) if (!ipv6_mc_may_pull(skb, len + grec_len))
return -EINVAL; return -EINVAL;