new helper: inode_wrong_type()
commit 6e3e2c4362e41a2f18e3f7a5ad81bd2f49a47b85 upstream. inode_wrong_type(inode, mode) returns true if setting inode->i_mode to given value would've changed the inode type. We have enough of those checks open-coded to make a helper worthwhile. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
ded9137fcf
commit
40ba433a85
@@ -376,7 +376,7 @@ nfsd_proc_create(struct svc_rqst *rqstp)
|
||||
|
||||
/* Make sure the type and device matches */
|
||||
resp->status = nfserr_exist;
|
||||
if (inode && type != (inode->i_mode & S_IFMT))
|
||||
if (inode && inode_wrong_type(inode, type))
|
||||
goto out_unlock;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user