fls: change parameter to unsigned int
When testing in userspace, UBSAN pointed out that shifting into the sign bit is undefined behaviour. It doesn't really make sense to ask for the highest set bit of a negative value, so just turn the argument type into an unsigned int. Some architectures (eg ppc) already had it declared as an unsigned int, so I don't expect too many problems. Link: http://lkml.kernel.org/r/20181105221117.31828-1-willy@infradead.org Signed-off-by: Matthew Wilcox <willy@infradead.org> Acked-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Этот коммит содержится в:

коммит произвёл
Linus Torvalds

родитель
e6310f0fb5
Коммит
3fc2579e6f
@@ -40,7 +40,7 @@ static __always_inline unsigned long __ffs(unsigned long x)
|
||||
/*
|
||||
* asm-generic/bitops/fls.h
|
||||
*/
|
||||
static __always_inline int fls(int x)
|
||||
static __always_inline int fls(unsigned int x)
|
||||
{
|
||||
asm volatile(
|
||||
"ff1 %0\n"
|
||||
|
Ссылка в новой задаче
Block a user