xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers/video: fsl-diu-fb: use a normal for-loop to uninstall framebuffers

Browse Source 
Uninstalling the framebuffers in reverse order is unnecessary and makes
the for-loop awkward.

Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
This commit is contained in:
Timur Tabi
2011-09-15 16:44:56 -05:00
committed by Florian Tobias Schandinat
parent 589c797193
commit 3f78bbd1a2
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/video/fsl-diu-fb.c
View File

@@ -1543,9 +1543,9 @@ static int __devinit fsl_diu_probe(struct platform_device *pdev)
return 0; return 0;
error: error:
for (i = ARRAY_SIZE(machine_data->fsl_diu_info); for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
i > 0; i--) uninstall_fb(machine_data->fsl_diu_info[i]);
uninstall_fb(machine_data->fsl_diu_info[i - 1]);
if (pool.ad.vaddr) if (pool.ad.vaddr)
free_buf(&pdev->dev, &pool.ad, free_buf(&pdev->dev, &pool.ad,
sizeof(struct diu_ad) * FSL_AOI_NUM, 8); sizeof(struct diu_ad) * FSL_AOI_NUM, 8);
@@ -1575,8 +1575,8 @@ static int fsl_diu_remove(struct platform_device *pdev)
machine_data = dev_get_drvdata(&pdev->dev); machine_data = dev_get_drvdata(&pdev->dev);
disable_lcdc(machine_data->fsl_diu_info[0]); disable_lcdc(machine_data->fsl_diu_info[0]);
free_irq_local(machine_data->irq); free_irq_local(machine_data->irq);
for (i = ARRAY_SIZE(machine_data->fsl_diu_info); i > 0; i--) for (i = 0; i < ARRAY_SIZE(machine_data->fsl_diu_info); i++)
uninstall_fb(machine_data->fsl_diu_info[i - 1]); uninstall_fb(machine_data->fsl_diu_info[i]);
if (pool.ad.vaddr) if (pool.ad.vaddr)
free_buf(&pdev->dev, &pool.ad, free_buf(&pdev->dev, &pool.ad,
sizeof(struct diu_ad) * FSL_AOI_NUM, 8); sizeof(struct diu_ad) * FSL_AOI_NUM, 8);