xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sysfs: add sysfs_create/remove_groups()

Browse Source 
These functions are being open-coded in 3 different places in the driver
core, and other driver subsystems will want to start doing this as well,
so move it to the sysfs core to keep it all in one place, where we know
it is written properly.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2013-08-21 13:47:50 -07:00
parent fa2be40fe7
commit 3e9b2bae83
5 changed files with 64 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/base/core.c
View File

@@ -493,31 +493,13 @@ static void device_remove_bin_attributes(struct device *dev,
int device_add_groups(struct device *dev, const struct attribute_group **groups)
{
int error = 0;
int i;
if (groups) {
for (i = 0; groups[i]; i++) {
error = sysfs_create_group(&dev->kobj, groups[i]);
if (error) {
while (--i >= 0)
sysfs_remove_group(&dev->kobj,
groups[i]);
break;
}
}
}
return error;
return sysfs_create_groups(&dev->kobj, groups);
}
void device_remove_groups(struct device *dev,
const struct attribute_group **groups)
{
int i;
if (groups)
for (i = 0; groups[i]; i++)
sysfs_remove_group(&dev->kobj, groups[i]);
sysfs_remove_groups(&dev->kobj, groups);
}
static int device_add_attrs(struct device *dev)