xfs: poll waiting for quotacheck
Create a pwork destroy function that uses polling instead of uninterruptible sleep to wait for work items to finish so that we can touch the softlockup watchdog. IOWs, gross hack. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Brian Foster <bfoster@redhat.com>
This commit is contained in:
@@ -13,6 +13,7 @@
|
||||
#include "xfs_trace.h"
|
||||
#include "xfs_sysctl.h"
|
||||
#include "xfs_pwork.h"
|
||||
#include <linux/nmi.h>
|
||||
|
||||
/*
|
||||
* Parallel Work Queue
|
||||
@@ -46,6 +47,8 @@ xfs_pwork_work(
|
||||
error = pctl->work_fn(pctl->mp, pwork);
|
||||
if (error && !pctl->error)
|
||||
pctl->error = error;
|
||||
if (atomic_dec_and_test(&pctl->nr_work))
|
||||
wake_up(&pctl->poll_wait);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -74,6 +77,8 @@ xfs_pwork_init(
|
||||
pctl->work_fn = work_fn;
|
||||
pctl->error = 0;
|
||||
pctl->mp = mp;
|
||||
atomic_set(&pctl->nr_work, 0);
|
||||
init_waitqueue_head(&pctl->poll_wait);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -86,6 +91,7 @@ xfs_pwork_queue(
|
||||
{
|
||||
INIT_WORK(&pwork->work, xfs_pwork_work);
|
||||
pwork->pctl = pctl;
|
||||
atomic_inc(&pctl->nr_work);
|
||||
queue_work(pctl->wq, &pwork->work);
|
||||
}
|
||||
|
||||
@@ -99,6 +105,19 @@ xfs_pwork_destroy(
|
||||
return pctl->error;
|
||||
}
|
||||
|
||||
/*
|
||||
* Wait for the work to finish by polling completion status and touch the soft
|
||||
* lockup watchdog. This is for callers such as mount which hold locks.
|
||||
*/
|
||||
void
|
||||
xfs_pwork_poll(
|
||||
struct xfs_pwork_ctl *pctl)
|
||||
{
|
||||
while (wait_event_timeout(pctl->poll_wait,
|
||||
atomic_read(&pctl->nr_work) == 0, HZ) == 0)
|
||||
touch_softlockup_watchdog();
|
||||
}
|
||||
|
||||
/*
|
||||
* Return the amount of parallelism that the data device can handle, or 0 for
|
||||
* no limit.
|
||||
|
Reference in New Issue
Block a user