memcg: zap memcg_name argument of memcg_create_kmem_cache
Instead of passing the name of the memory cgroup which the cache is created for in the memcg_name_argument, let's obtain it immediately in memcg_create_kmem_cache. Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
dbf22eb6d8
commit
3e0350a364
@@ -430,16 +430,15 @@ EXPORT_SYMBOL(kmem_cache_create);
|
||||
* memcg_create_kmem_cache - Create a cache for a memory cgroup.
|
||||
* @memcg: The memory cgroup the new cache is for.
|
||||
* @root_cache: The parent of the new cache.
|
||||
* @memcg_name: The name of the memory cgroup (used for naming the new cache).
|
||||
*
|
||||
* This function attempts to create a kmem cache that will serve allocation
|
||||
* requests going from @memcg to @root_cache. The new cache inherits properties
|
||||
* from its parent.
|
||||
*/
|
||||
struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
|
||||
struct kmem_cache *root_cache,
|
||||
const char *memcg_name)
|
||||
struct kmem_cache *root_cache)
|
||||
{
|
||||
static char memcg_name_buf[NAME_MAX + 1]; /* protected by slab_mutex */
|
||||
struct kmem_cache *s = NULL;
|
||||
char *cache_name;
|
||||
|
||||
@@ -448,8 +447,10 @@ struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
|
||||
|
||||
mutex_lock(&slab_mutex);
|
||||
|
||||
cgroup_name(mem_cgroup_css(memcg)->cgroup,
|
||||
memcg_name_buf, sizeof(memcg_name_buf));
|
||||
cache_name = kasprintf(GFP_KERNEL, "%s(%d:%s)", root_cache->name,
|
||||
memcg_cache_id(memcg), memcg_name);
|
||||
memcg_cache_id(memcg), memcg_name_buf);
|
||||
if (!cache_name)
|
||||
goto out_unlock;
|
||||
|
||||
|
Reference in New Issue
Block a user