qed*: Handle-based L2-queues.
The driver needs to maintain several FW/HW-indices for each one of its queues. Currently, that mapping is done by the QED where it uses an rx/tx array of so-called hw-cids, populating them whenever a new queue is opened and clearing them upon destruction of said queues. This maintenance is far from ideal - there's no real reason why QED needs to maintain such a data-structure. It becomes even worse when considering the fact that the PF's queues and its child VFs' queues are all mapped into the same data-structure. As a by-product, the set of parameters an interface needs to supply for queue APIs is non-trivial, and some of the variables in the API structures have different meaning depending on their exact place in the configuration flow. This patch re-organizes the way L2 queues are configured and maintained. In short: - Required parameters for queue init are now well-defined. - Qed would allocate a queue-cid based on parameters. Upon initialization success, it would return a handle to caller. - Queue-handle would be maintained by entity requesting queue-init, not necessarily qed. - All further queue-APIs [update, destroy] would use the opaque handle as reference for the queue instead of various indices. The possible owners of such handles: - PF queues [qede] - complete handles based on provided configuration. - VF queues [qede] - fw-context-less handles, containing only relative information; Only the PF-side would need the absolute indices for configuration, so they're omitted here. - VF queues [qed, PF-side] - complete handles based on VF initialization. Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
567b3c127a
commit
3da7a37ae6
@@ -15,6 +15,29 @@
|
||||
#include <linux/qed/qed_if.h>
|
||||
#include <linux/qed/qed_iov_if.h>
|
||||
|
||||
struct qed_queue_start_common_params {
|
||||
/* Should always be relative to entity sending this. */
|
||||
u8 vport_id;
|
||||
u16 queue_id;
|
||||
|
||||
/* Relative, but relevant only for PFs */
|
||||
u8 stats_id;
|
||||
|
||||
/* These are always absolute */
|
||||
u16 sb;
|
||||
u8 sb_idx;
|
||||
};
|
||||
|
||||
struct qed_rxq_start_ret_params {
|
||||
void __iomem *p_prod;
|
||||
void *p_handle;
|
||||
};
|
||||
|
||||
struct qed_txq_start_ret_params {
|
||||
void __iomem *p_doorbell;
|
||||
void *p_handle;
|
||||
};
|
||||
|
||||
struct qed_dev_eth_info {
|
||||
struct qed_dev_info common;
|
||||
|
||||
@@ -56,18 +79,6 @@ struct qed_start_vport_params {
|
||||
bool clear_stats;
|
||||
};
|
||||
|
||||
struct qed_stop_rxq_params {
|
||||
u8 rss_id;
|
||||
u8 rx_queue_id;
|
||||
u8 vport_id;
|
||||
bool eq_completion_only;
|
||||
};
|
||||
|
||||
struct qed_stop_txq_params {
|
||||
u8 rss_id;
|
||||
u8 tx_queue_id;
|
||||
};
|
||||
|
||||
enum qed_filter_rx_mode_type {
|
||||
QED_FILTER_RX_MODE_TYPE_REGULAR,
|
||||
QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC,
|
||||
@@ -112,15 +123,6 @@ struct qed_filter_params {
|
||||
union qed_filter_type_params filter;
|
||||
};
|
||||
|
||||
struct qed_queue_start_common_params {
|
||||
u8 rss_id;
|
||||
u8 queue_id;
|
||||
u8 vport_id;
|
||||
u16 sb;
|
||||
u16 sb_idx;
|
||||
u16 vf_qid;
|
||||
};
|
||||
|
||||
struct qed_tunn_params {
|
||||
u16 vxlan_port;
|
||||
u8 update_vxlan_port;
|
||||
@@ -220,24 +222,24 @@ struct qed_eth_ops {
|
||||
struct qed_update_vport_params *params);
|
||||
|
||||
int (*q_rx_start)(struct qed_dev *cdev,
|
||||
u8 rss_num,
|
||||
struct qed_queue_start_common_params *params,
|
||||
u16 bd_max_bytes,
|
||||
dma_addr_t bd_chain_phys_addr,
|
||||
dma_addr_t cqe_pbl_addr,
|
||||
u16 cqe_pbl_size,
|
||||
void __iomem **pp_prod);
|
||||
struct qed_rxq_start_ret_params *ret_params);
|
||||
|
||||
int (*q_rx_stop)(struct qed_dev *cdev,
|
||||
struct qed_stop_rxq_params *params);
|
||||
int (*q_rx_stop)(struct qed_dev *cdev, u8 rss_id, void *handle);
|
||||
|
||||
int (*q_tx_start)(struct qed_dev *cdev,
|
||||
u8 rss_num,
|
||||
struct qed_queue_start_common_params *params,
|
||||
dma_addr_t pbl_addr,
|
||||
u16 pbl_size,
|
||||
void __iomem **pp_doorbell);
|
||||
struct qed_txq_start_ret_params *ret_params);
|
||||
|
||||
int (*q_tx_stop)(struct qed_dev *cdev,
|
||||
struct qed_stop_txq_params *params);
|
||||
int (*q_tx_stop)(struct qed_dev *cdev, u8 rss_id, void *handle);
|
||||
|
||||
int (*filter_config)(struct qed_dev *cdev,
|
||||
struct qed_filter_params *params);
|
||||
|
Reference in New Issue
Block a user