[PATCH] knfsd: Avoid excess stack usage in svc_tcp_recvfrom
.. by allocating the array of 'kvec' in 'struct svc_rqst'. As we plan to increase RPCSVC_MAXPAGES from 8 upto 256, we can no longer allocate an array of this size on the stack. So we allocate it in 'struct svc_rqst'. However svc_rqst contains (indirectly) an array of the same type and size (actually several, but they are in a union). So rather than waste space, we move those arrays out of the separately allocated union and into svc_rqst to share with the kvec moved out of svc_tcp_recvfrom (various arrays are used at different times, so there is no conflict). Signed-off-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:

committed by
Linus Torvalds

parent
4452435948
commit
3cc03b164c
@@ -646,7 +646,7 @@ nfsd4_write(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfsd4_writ
|
||||
*p++ = nfssvc_boot.tv_usec;
|
||||
|
||||
status = nfsd_write(rqstp, current_fh, filp, write->wr_offset,
|
||||
write->wr_vec, write->wr_vlen, write->wr_buflen,
|
||||
rqstp->rq_vec, write->wr_vlen, write->wr_buflen,
|
||||
&write->wr_how_written);
|
||||
if (filp)
|
||||
fput(filp);
|
||||
|
Reference in New Issue
Block a user