iwlwifi: add missing trailing newlines to debug messages
All messages should have a trailing newline, add all the missing ones. Also make all messages constants, replacing the single one that pointlessly used a variable. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
This commit is contained in:

کامیت شده توسط
Emmanuel Grumbach

والد
017a64161f
کامیت
3c6acb614d
@@ -987,7 +987,7 @@ static void iwl_bg_restart(struct work_struct *data)
|
||||
ieee80211_restart_hw(priv->hw);
|
||||
else
|
||||
IWL_ERR(priv,
|
||||
"Cannot request restart before registrating with mac80211");
|
||||
"Cannot request restart before registrating with mac80211\n");
|
||||
} else {
|
||||
WARN_ON(1);
|
||||
}
|
||||
@@ -1127,7 +1127,6 @@ static void iwl_option_config(struct iwl_priv *priv)
|
||||
static int iwl_eeprom_init_hw_params(struct iwl_priv *priv)
|
||||
{
|
||||
struct iwl_nvm_data *data = priv->nvm_data;
|
||||
char *debug_msg;
|
||||
|
||||
if (data->sku_cap_11n_enable &&
|
||||
!priv->cfg->ht_params) {
|
||||
@@ -1141,8 +1140,8 @@ static int iwl_eeprom_init_hw_params(struct iwl_priv *priv)
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
debug_msg = "Device SKU: 24GHz %s %s, 52GHz %s %s, 11.n %s %s\n";
|
||||
IWL_DEBUG_INFO(priv, debug_msg,
|
||||
IWL_DEBUG_INFO(priv,
|
||||
"Device SKU: 24GHz %s %s, 52GHz %s %s, 11.n %s %s\n",
|
||||
data->sku_cap_band_24GHz_enable ? "" : "NOT", "enabled",
|
||||
data->sku_cap_band_52GHz_enable ? "" : "NOT", "enabled",
|
||||
data->sku_cap_11n_enable ? "" : "NOT", "enabled");
|
||||
@@ -1350,7 +1349,7 @@ static struct iwl_op_mode *iwl_op_mode_dvm_start(struct iwl_trans *trans,
|
||||
iwl_set_hw_params(priv);
|
||||
|
||||
if (!(priv->nvm_data->sku_cap_ipan_enable)) {
|
||||
IWL_DEBUG_INFO(priv, "Your EEPROM disabled PAN");
|
||||
IWL_DEBUG_INFO(priv, "Your EEPROM disabled PAN\n");
|
||||
ucode_flags &= ~IWL_UCODE_TLV_FLAGS_PAN;
|
||||
/*
|
||||
* if not PAN, then don't support P2P -- might be a uCode
|
||||
@@ -2019,10 +2018,10 @@ void iwlagn_lift_passive_no_rx(struct iwl_priv *priv)
|
||||
|
||||
for (mq = 0; mq < IWLAGN_FIRST_AMPDU_QUEUE; mq++) {
|
||||
if (!test_bit(mq, &priv->transport_queue_stop)) {
|
||||
IWL_DEBUG_TX_QUEUES(priv, "Wake queue %d", mq);
|
||||
IWL_DEBUG_TX_QUEUES(priv, "Wake queue %d\n", mq);
|
||||
ieee80211_wake_queue(priv->hw, mq);
|
||||
} else {
|
||||
IWL_DEBUG_TX_QUEUES(priv, "Don't wake queue %d", mq);
|
||||
IWL_DEBUG_TX_QUEUES(priv, "Don't wake queue %d\n", mq);
|
||||
}
|
||||
}
|
||||
|
||||
|
@@ -361,7 +361,7 @@ int iwl_power_set_mode(struct iwl_priv *priv, struct iwl_powertable_cmd *cmd,
|
||||
|
||||
memcpy(&priv->power_data.sleep_cmd, cmd, sizeof(*cmd));
|
||||
} else
|
||||
IWL_ERR(priv, "set power fail, ret = %d", ret);
|
||||
IWL_ERR(priv, "set power fail, ret = %d\n", ret);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
@@ -1453,7 +1453,7 @@ static int rs_move_legacy_other(struct iwl_priv *priv,
|
||||
tbl->action = IWL_LEGACY_SWITCH_SISO;
|
||||
break;
|
||||
default:
|
||||
IWL_ERR(priv, "Invalid BT load %d", priv->bt_traffic_load);
|
||||
IWL_ERR(priv, "Invalid BT load %d\n", priv->bt_traffic_load);
|
||||
break;
|
||||
}
|
||||
|
||||
@@ -1628,7 +1628,7 @@ static int rs_move_siso_to_other(struct iwl_priv *priv,
|
||||
tbl->action = IWL_SISO_SWITCH_ANTENNA1;
|
||||
break;
|
||||
default:
|
||||
IWL_ERR(priv, "Invalid BT load %d", priv->bt_traffic_load);
|
||||
IWL_ERR(priv, "Invalid BT load %d\n", priv->bt_traffic_load);
|
||||
break;
|
||||
}
|
||||
|
||||
@@ -1799,7 +1799,7 @@ static int rs_move_mimo2_to_other(struct iwl_priv *priv,
|
||||
tbl->action = IWL_MIMO2_SWITCH_SISO_A;
|
||||
break;
|
||||
default:
|
||||
IWL_ERR(priv, "Invalid BT load %d", priv->bt_traffic_load);
|
||||
IWL_ERR(priv, "Invalid BT load %d\n", priv->bt_traffic_load);
|
||||
break;
|
||||
}
|
||||
|
||||
@@ -1969,7 +1969,7 @@ static int rs_move_mimo3_to_other(struct iwl_priv *priv,
|
||||
tbl->action = IWL_MIMO3_SWITCH_SISO_A;
|
||||
break;
|
||||
default:
|
||||
IWL_ERR(priv, "Invalid BT load %d", priv->bt_traffic_load);
|
||||
IWL_ERR(priv, "Invalid BT load %d\n", priv->bt_traffic_load);
|
||||
break;
|
||||
}
|
||||
|
||||
|
@@ -823,7 +823,7 @@ static int iwl_check_rxon_cmd(struct iwl_priv *priv,
|
||||
|
||||
if ((rxon->flags & (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK))
|
||||
== (RXON_FLG_CCK_MSK | RXON_FLG_AUTO_DETECT_MSK)) {
|
||||
IWL_WARN(priv, "CCK and auto detect");
|
||||
IWL_WARN(priv, "CCK and auto detect\n");
|
||||
errors |= BIT(8);
|
||||
}
|
||||
|
||||
|
@@ -39,7 +39,7 @@ static int iwl_sta_ucode_activate(struct iwl_priv *priv, u8 sta_id)
|
||||
lockdep_assert_held(&priv->sta_lock);
|
||||
|
||||
if (sta_id >= IWLAGN_STATION_COUNT) {
|
||||
IWL_ERR(priv, "invalid sta_id %u", sta_id);
|
||||
IWL_ERR(priv, "invalid sta_id %u\n", sta_id);
|
||||
return -EINVAL;
|
||||
}
|
||||
if (!(priv->stations[sta_id].used & IWL_STA_DRIVER_ACTIVE))
|
||||
@@ -165,7 +165,7 @@ int iwl_send_add_sta(struct iwl_priv *priv,
|
||||
iwl_free_resp(&cmd);
|
||||
|
||||
if (cmd.handler_status)
|
||||
IWL_ERR(priv, "%s - error in the CMD response %d", __func__,
|
||||
IWL_ERR(priv, "%s - error in the CMD response %d\n", __func__,
|
||||
cmd.handler_status);
|
||||
|
||||
return cmd.handler_status;
|
||||
|
@@ -402,10 +402,10 @@ int iwlagn_tx_skb(struct iwl_priv *priv,
|
||||
/* aggregation is on for this <sta,tid> */
|
||||
if (info->flags & IEEE80211_TX_CTL_AMPDU &&
|
||||
tid_data->agg.state != IWL_AGG_ON) {
|
||||
IWL_ERR(priv, "TX_CTL_AMPDU while not in AGG:"
|
||||
" Tx flags = 0x%08x, agg.state = %d",
|
||||
IWL_ERR(priv,
|
||||
"TX_CTL_AMPDU while not in AGG: Tx flags = 0x%08x, agg.state = %d\n",
|
||||
info->flags, tid_data->agg.state);
|
||||
IWL_ERR(priv, "sta_id = %d, tid = %d seq_num = %d",
|
||||
IWL_ERR(priv, "sta_id = %d, tid = %d seq_num = %d\n",
|
||||
sta_id, tid,
|
||||
IEEE80211_SEQ_TO_SN(tid_data->seq_number));
|
||||
goto drop_unlock_sta;
|
||||
@@ -416,7 +416,7 @@ int iwlagn_tx_skb(struct iwl_priv *priv,
|
||||
*/
|
||||
if (WARN_ONCE(tid_data->agg.state != IWL_AGG_ON &&
|
||||
tid_data->agg.state != IWL_AGG_OFF,
|
||||
"Tx while agg.state = %d", tid_data->agg.state))
|
||||
"Tx while agg.state = %d\n", tid_data->agg.state))
|
||||
goto drop_unlock_sta;
|
||||
|
||||
seq_number = tid_data->seq_number;
|
||||
@@ -778,8 +778,8 @@ static void iwlagn_check_ratid_empty(struct iwl_priv *priv, int sta_id, u8 tid)
|
||||
/* There are no packets for this RA / TID in the HW any more */
|
||||
if (tid_data->agg.ssn == tid_data->next_reclaimed) {
|
||||
IWL_DEBUG_TX_QUEUES(priv,
|
||||
"Can continue DELBA flow ssn = next_recl ="
|
||||
" %d", tid_data->next_reclaimed);
|
||||
"Can continue DELBA flow ssn = next_recl = %d\n",
|
||||
tid_data->next_reclaimed);
|
||||
iwl_trans_txq_disable(priv->trans,
|
||||
tid_data->agg.txq_id);
|
||||
iwlagn_dealloc_agg_txq(priv, tid_data->agg.txq_id);
|
||||
@@ -791,8 +791,8 @@ static void iwlagn_check_ratid_empty(struct iwl_priv *priv, int sta_id, u8 tid)
|
||||
/* There are no packets for this RA / TID in the HW any more */
|
||||
if (tid_data->agg.ssn == tid_data->next_reclaimed) {
|
||||
IWL_DEBUG_TX_QUEUES(priv,
|
||||
"Can continue ADDBA flow ssn = next_recl ="
|
||||
" %d", tid_data->next_reclaimed);
|
||||
"Can continue ADDBA flow ssn = next_recl = %d\n",
|
||||
tid_data->next_reclaimed);
|
||||
tid_data->agg.state = IWL_AGG_STARTING;
|
||||
ieee80211_start_tx_ba_cb_irqsafe(vif, addr, tid);
|
||||
}
|
||||
@@ -1216,8 +1216,8 @@ int iwlagn_rx_reply_tx(struct iwl_priv *priv, struct iwl_rx_cmd_buffer *rxb,
|
||||
ctx->vif->type == NL80211_IFTYPE_STATION) {
|
||||
/* block and stop all queues */
|
||||
priv->passive_no_rx = true;
|
||||
IWL_DEBUG_TX_QUEUES(priv, "stop all queues: "
|
||||
"passive channel");
|
||||
IWL_DEBUG_TX_QUEUES(priv,
|
||||
"stop all queues: passive channel\n");
|
||||
ieee80211_stop_queues(priv->hw);
|
||||
|
||||
IWL_DEBUG_TX_REPLY(priv,
|
||||
|
مرجع در شماره جدید
Block a user