Merge branch 'work.misc-set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull misc user access cleanups from Al Viro: "The first pile is assorted getting rid of cargo-culted access_ok(), cargo-culted set_fs() and field-by-field copyouts. The same description applies to a lot of stuff in other branches - this is just the stuff that didn't fit into a more specific topical branch" * 'work.misc-set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: Switch flock copyin/copyout primitives to copy_{from,to}_user() fs/fcntl: return -ESRCH in f_setown when pid/pgid can't be found fs/fcntl: f_setown, avoid undefined behaviour fs/fcntl: f_setown, allow returning error lpfc debugfs: get rid of pointless access_ok() adb: get rid of pointless access_ok() isdn: get rid of pointless access_ok() compat statfs: switch to copy_to_user() fs/locks: don't mess with the address limit in compat_fcntl64 nfsd_readlink(): switch to vfs_get_link() drbd: ->sendpage() never needed set_fs() fs/locks: pass kernel struct flock to fcntl_getlk/setlk fs: locks: Fix some troubles at kernel-doc comments
This commit is contained in:
@@ -1949,10 +1949,6 @@ lpfc_debugfs_nvmestat_write(struct file *file, const char __user *buf,
|
||||
if (nbytes > 64)
|
||||
nbytes = 64;
|
||||
|
||||
/* Protect copy from user */
|
||||
if (!access_ok(VERIFY_READ, buf, nbytes))
|
||||
return -EFAULT;
|
||||
|
||||
memset(mybuf, 0, sizeof(mybuf));
|
||||
|
||||
if (copy_from_user(mybuf, buf, nbytes))
|
||||
@@ -2037,10 +2033,6 @@ lpfc_debugfs_nvmektime_write(struct file *file, const char __user *buf,
|
||||
if (nbytes > 64)
|
||||
nbytes = 64;
|
||||
|
||||
/* Protect copy from user */
|
||||
if (!access_ok(VERIFY_READ, buf, nbytes))
|
||||
return -EFAULT;
|
||||
|
||||
memset(mybuf, 0, sizeof(mybuf));
|
||||
|
||||
if (copy_from_user(mybuf, buf, nbytes))
|
||||
@@ -2169,10 +2161,6 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf,
|
||||
if (nbytes > 64)
|
||||
nbytes = 64;
|
||||
|
||||
/* Protect copy from user */
|
||||
if (!access_ok(VERIFY_READ, buf, nbytes))
|
||||
return -EFAULT;
|
||||
|
||||
memset(mybuf, 0, sizeof(mybuf));
|
||||
|
||||
if (copy_from_user(mybuf, buf, nbytes))
|
||||
@@ -2280,10 +2268,6 @@ lpfc_debugfs_cpucheck_write(struct file *file, const char __user *buf,
|
||||
if (nbytes > 64)
|
||||
nbytes = 64;
|
||||
|
||||
/* Protect copy from user */
|
||||
if (!access_ok(VERIFY_READ, buf, nbytes))
|
||||
return -EFAULT;
|
||||
|
||||
memset(mybuf, 0, sizeof(mybuf));
|
||||
|
||||
if (copy_from_user(mybuf, buf, nbytes))
|
||||
@@ -2354,10 +2338,6 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes,
|
||||
int i;
|
||||
size_t bsize;
|
||||
|
||||
/* Protect copy from user */
|
||||
if (!access_ok(VERIFY_READ, buf, nbytes))
|
||||
return -EFAULT;
|
||||
|
||||
memset(mybuf, 0, sizeof(mybuf));
|
||||
memset(idiag_cmd, 0, sizeof(*idiag_cmd));
|
||||
bsize = min(nbytes, (sizeof(mybuf)-1));
|
||||
|
Reference in New Issue
Block a user