drm/radeon: rework fence handling, drop fence list v7
Using 64bits fence sequence we can directly compare sequence number to know if a fence is signaled or not. Thus the fence list became useless, so does the fence lock that mainly protected the fence list. Things like ring.ready are no longer behind a lock, this should be ok as ring.ready is initialized once and will only change when facing lockup. Worst case is that we return an -EBUSY just after a successfull GPU reset, or we go into wait state instead of returning -EBUSY (thus delaying reporting -EBUSY to fence wait caller). v2: Remove left over comment, force using writeback on cayman and newer, thus not having to suffer from possibly scratch reg exhaustion v3: Rebase on top of change to uint64 fence patch v4: Change DCE5 test to force write back on cayman and newer but also any APU such as PALM or SUMO family v5: Rebase on top of new uint64 fence patch v6: Just break if seq doesn't change any more. Use radeon_fence prefix for all function names. Even if it's now highly optimized, try avoiding polling to often. v7: We should never poll the last_seq from the hardware without waking the sleeping threads, otherwise we might lose events. Signed-off-by: Jerome Glisse <jglisse@redhat.com> Signed-off-by: Christian König <deathsimple@vodafone.de> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:

committed by
Dave Airlie

parent
bb63556729
commit
3b7a2b24ea
@@ -225,9 +225,9 @@ int radeon_wb_init(struct radeon_device *rdev)
|
||||
/* disable event_write fences */
|
||||
rdev->wb.use_event = false;
|
||||
/* disabled via module param */
|
||||
if (radeon_no_wb == 1)
|
||||
if (radeon_no_wb == 1) {
|
||||
rdev->wb.enabled = false;
|
||||
else {
|
||||
} else {
|
||||
if (rdev->flags & RADEON_IS_AGP) {
|
||||
/* often unreliable on AGP */
|
||||
rdev->wb.enabled = false;
|
||||
@@ -237,8 +237,9 @@ int radeon_wb_init(struct radeon_device *rdev)
|
||||
} else {
|
||||
rdev->wb.enabled = true;
|
||||
/* event_write fences are only available on r600+ */
|
||||
if (rdev->family >= CHIP_R600)
|
||||
if (rdev->family >= CHIP_R600) {
|
||||
rdev->wb.use_event = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
/* always use writeback/events on NI, APUs */
|
||||
@@ -731,7 +732,6 @@ int radeon_device_init(struct radeon_device *rdev,
|
||||
mutex_init(&rdev->gem.mutex);
|
||||
mutex_init(&rdev->pm.mutex);
|
||||
mutex_init(&rdev->vram_mutex);
|
||||
rwlock_init(&rdev->fence_lock);
|
||||
rwlock_init(&rdev->semaphore_drv.lock);
|
||||
INIT_LIST_HEAD(&rdev->gem.objects);
|
||||
init_waitqueue_head(&rdev->irq.vblank_queue);
|
||||
|
Reference in New Issue
Block a user