xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scripts/bloat-o-meter: don't use readlines()

Browse Source 
readlines() conses whole list before doing anything which is slower for
big object files.  Use per line iterator.

Speed up is ~2% on "allyesconfig" type of kernel.

    $ perf stat -r 16 taskset -c 15 ./scripts/bloat-o-meter ../vmlinux-000 ../obj/vmlinux >/dev/null
	...

  Before:  7.247708646 seconds time elapsed                ( +-  0.28% )
  After:   7.091202853 seconds time elapsed                ( +-  0.15% )

Link: http://lkml.kernel.org/r/20161119004143.GA1200@avx2
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan
2016-12-12 16:40:45 -08:00
committed by Linus Torvalds
parent 3fb4afd9a5
commit 3af06fd96a
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
scripts/bloat-o-meter
View File

@@ -18,17 +18,18 @@ if len(sys.argv) != 3:
def getsizes(file): def getsizes(file):
sym = {} sym = {}
for l in os.popen("nm --size-sort " + file).readlines(): with os.popen("nm --size-sort " + file) as f:
size, type, name = l[:-1].split() for line in f:
if type in "tTdDbBrR": size, type, name = line.split()
# strip generated symbols if type in "tTdDbBrR":
if name.startswith("__mod_"): continue # strip generated symbols
if name.startswith("SyS_"): continue if name.startswith("__mod_"): continue
if name.startswith("compat_SyS_"): continue if name.startswith("SyS_"): continue
if name == "linux_banner": continue if name.startswith("compat_SyS_"): continue
# statics and some other optimizations adds random .NUMBER if name == "linux_banner": continue
name = re.sub(r'\.[0-9]+', '', name) # statics and some other optimizations adds random .NUMBER
sym[name] = sym.get(name, 0) + int(size, 16) name = re.sub(r'\.[0-9]+', '', name)
sym[name] = sym.get(name, 0) + int(size, 16)
return sym return sym
old = getsizes(sys.argv[1]) old = getsizes(sys.argv[1])