ALSA: sound/isa: constify snd_kcontrol_new structures
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle: @r disable optional_qualifier@ identifier x; position p; @@ static struct snd_kcontrol_new x@p={...}; @ok@ identifier r.x; position p; @@ snd_ctl_new1(&x@p,...) @bad@ position p != {r.p,ok.p}; identifier r.x; @@ x@p @depends on !bad disable optional_qualifier@ identifier r.x; @@ +const struct snd_kcontrol_new x; Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Šī revīzija ir iekļauta:

revīziju iesūtīja
Takashi Iwai

vecāks
e0327a0f21
revīzija
3a84d6c940
@@ -82,7 +82,7 @@ static int snd_gus_joystick_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
|
||||
return change;
|
||||
}
|
||||
|
||||
static struct snd_kcontrol_new snd_gus_joystick_control = {
|
||||
static const struct snd_kcontrol_new snd_gus_joystick_control = {
|
||||
.iface = SNDRV_CTL_ELEM_IFACE_CARD,
|
||||
.name = "Joystick Speed",
|
||||
.info = snd_gus_joystick_info,
|
||||
|
@@ -809,7 +809,7 @@ static int snd_gf1_pcm_volume_put(struct snd_kcontrol *kcontrol, struct snd_ctl_
|
||||
return change;
|
||||
}
|
||||
|
||||
static struct snd_kcontrol_new snd_gf1_pcm_volume_control =
|
||||
static const struct snd_kcontrol_new snd_gf1_pcm_volume_control =
|
||||
{
|
||||
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
|
||||
.name = "PCM Playback Volume",
|
||||
@@ -818,7 +818,7 @@ static struct snd_kcontrol_new snd_gf1_pcm_volume_control =
|
||||
.put = snd_gf1_pcm_volume_put
|
||||
};
|
||||
|
||||
static struct snd_kcontrol_new snd_gf1_pcm_volume_control1 =
|
||||
static const struct snd_kcontrol_new snd_gf1_pcm_volume_control1 =
|
||||
{
|
||||
.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
|
||||
.name = "GPCM Playback Volume",
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user