fs: Preserve error code in get_empty_filp(), part 2
Allocating a file structure in function get_empty_filp() might fail because of several reasons: - not enough memory for file structures - operation is not allowed - user is over its limit Currently the function returns NULL in all cases and we loose the exact reason of the error. All callers of get_empty_filp() assume that the function can fail with ENFILE only. Return error through pointer. Change all callers to preserve this error code. [AV: cleaned up a bit, carved the get_empty_filp() part out into a separate commit (things remaining here deal with alloc_file()), removed pipe(2) behaviour change] Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com> Reviewed-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
@@ -173,7 +173,7 @@ struct file *alloc_file(struct path *path, fmode_t mode,
|
||||
|
||||
file = get_empty_filp();
|
||||
if (IS_ERR(file))
|
||||
return NULL;
|
||||
return file;
|
||||
|
||||
file->f_path = *path;
|
||||
file->f_mapping = path->dentry->d_inode->i_mapping;
|
||||
|
Reference in New Issue
Block a user