xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ethernet: Delete unnecessary checks before the macro call “dev_kfree_skb”

Browse Source 
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring
2019-08-22 20:02:56 +02:00
committed by David S. Miller
parent 5477fccf9a
commit 399e06a517
20 changed files with 27 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/ethernet/ibm/ehea/ehea_main.c
View File

@@ -1577,20 +1577,16 @@ static int ehea_clean_portres(struct ehea_port *port, struct ehea_port_res *pr)
ehea_destroy_eq(pr->eq);
for (i = 0; i < pr->rq1_skba.len; i++)
if (pr->rq1_skba.arr[i])
dev_kfree_skb(pr->rq1_skba.arr[i]);
dev_kfree_skb(pr->rq1_skba.arr[i]);
for (i = 0; i < pr->rq2_skba.len; i++)
if (pr->rq2_skba.arr[i])
dev_kfree_skb(pr->rq2_skba.arr[i]);
dev_kfree_skb(pr->rq2_skba.arr[i]);
for (i = 0; i < pr->rq3_skba.len; i++)
if (pr->rq3_skba.arr[i])
dev_kfree_skb(pr->rq3_skba.arr[i]);
dev_kfree_skb(pr->rq3_skba.arr[i]);
for (i = 0; i < pr->sq_skba.len; i++)
if (pr->sq_skba.arr[i])
dev_kfree_skb(pr->sq_skba.arr[i]);
dev_kfree_skb(pr->sq_skba.arr[i]);
vfree(pr->rq1_skba.arr);
vfree(pr->rq2_skba.arr);