drm/amd/amdgpu: Make debugfs write compliment read
Add PG lock support as well as bank selection to the MMIO write function. Signed-off-by: Tom St Denis <tom.stdenis@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:

committed by
Alex Deucher

parent
32977f93b4
commit
394fdde256
@@ -2639,10 +2639,45 @@ static ssize_t amdgpu_debugfs_regs_write(struct file *f, const char __user *buf,
|
|||||||
struct amdgpu_device *adev = f->f_inode->i_private;
|
struct amdgpu_device *adev = f->f_inode->i_private;
|
||||||
ssize_t result = 0;
|
ssize_t result = 0;
|
||||||
int r;
|
int r;
|
||||||
|
bool pm_pg_lock, use_bank;
|
||||||
|
unsigned instance_bank, sh_bank, se_bank;
|
||||||
|
|
||||||
if (size & 0x3 || *pos & 0x3)
|
if (size & 0x3 || *pos & 0x3)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
|
/* are we reading registers for which a PG lock is necessary? */
|
||||||
|
pm_pg_lock = (*pos >> 23) & 1;
|
||||||
|
|
||||||
|
if (*pos & (1ULL << 62)) {
|
||||||
|
se_bank = (*pos >> 24) & 0x3FF;
|
||||||
|
sh_bank = (*pos >> 34) & 0x3FF;
|
||||||
|
instance_bank = (*pos >> 44) & 0x3FF;
|
||||||
|
|
||||||
|
if (se_bank == 0x3FF)
|
||||||
|
se_bank = 0xFFFFFFFF;
|
||||||
|
if (sh_bank == 0x3FF)
|
||||||
|
sh_bank = 0xFFFFFFFF;
|
||||||
|
if (instance_bank == 0x3FF)
|
||||||
|
instance_bank = 0xFFFFFFFF;
|
||||||
|
use_bank = 1;
|
||||||
|
} else {
|
||||||
|
use_bank = 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
*pos &= 0x3FFFF;
|
||||||
|
|
||||||
|
if (use_bank) {
|
||||||
|
if ((sh_bank != 0xFFFFFFFF && sh_bank >= adev->gfx.config.max_sh_per_se) ||
|
||||||
|
(se_bank != 0xFFFFFFFF && se_bank >= adev->gfx.config.max_shader_engines))
|
||||||
|
return -EINVAL;
|
||||||
|
mutex_lock(&adev->grbm_idx_mutex);
|
||||||
|
amdgpu_gfx_select_se_sh(adev, se_bank,
|
||||||
|
sh_bank, instance_bank);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (pm_pg_lock)
|
||||||
|
mutex_lock(&adev->pm.mutex);
|
||||||
|
|
||||||
while (size) {
|
while (size) {
|
||||||
uint32_t value;
|
uint32_t value;
|
||||||
|
|
||||||
@@ -2661,6 +2696,14 @@ static ssize_t amdgpu_debugfs_regs_write(struct file *f, const char __user *buf,
|
|||||||
size -= 4;
|
size -= 4;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (use_bank) {
|
||||||
|
amdgpu_gfx_select_se_sh(adev, 0xffffffff, 0xffffffff, 0xffffffff);
|
||||||
|
mutex_unlock(&adev->grbm_idx_mutex);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (pm_pg_lock)
|
||||||
|
mutex_unlock(&adev->pm.mutex);
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user