ext4: Remove ext4_get_inode_flags()
Now that all places setting inode->i_flags that should be reflected in on-disk flags are gone, we can remove ext4_get_inode_flags() call. Reviewed-by: Andreas Dilger <adilger@dilger.ca> Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
@@ -4502,31 +4502,6 @@ void ext4_set_inode_flags(struct inode *inode)
|
||||
S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_DAX);
|
||||
}
|
||||
|
||||
/* Propagate flags from i_flags to EXT4_I(inode)->i_flags */
|
||||
void ext4_get_inode_flags(struct ext4_inode_info *ei)
|
||||
{
|
||||
unsigned int vfs_fl;
|
||||
unsigned long old_fl, new_fl;
|
||||
|
||||
do {
|
||||
vfs_fl = ei->vfs_inode.i_flags;
|
||||
old_fl = ei->i_flags;
|
||||
new_fl = old_fl & ~(EXT4_SYNC_FL|EXT4_APPEND_FL|
|
||||
EXT4_IMMUTABLE_FL|EXT4_NOATIME_FL|
|
||||
EXT4_DIRSYNC_FL);
|
||||
if (vfs_fl & S_SYNC)
|
||||
new_fl |= EXT4_SYNC_FL;
|
||||
if (vfs_fl & S_APPEND)
|
||||
new_fl |= EXT4_APPEND_FL;
|
||||
if (vfs_fl & S_IMMUTABLE)
|
||||
new_fl |= EXT4_IMMUTABLE_FL;
|
||||
if (vfs_fl & S_NOATIME)
|
||||
new_fl |= EXT4_NOATIME_FL;
|
||||
if (vfs_fl & S_DIRSYNC)
|
||||
new_fl |= EXT4_DIRSYNC_FL;
|
||||
} while (cmpxchg(&ei->i_flags, old_fl, new_fl) != old_fl);
|
||||
}
|
||||
|
||||
static blkcnt_t ext4_inode_blocks(struct ext4_inode *raw_inode,
|
||||
struct ext4_inode_info *ei)
|
||||
{
|
||||
@@ -4963,7 +4938,6 @@ static int ext4_do_update_inode(handle_t *handle,
|
||||
if (ext4_test_inode_state(inode, EXT4_STATE_NEW))
|
||||
memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size);
|
||||
|
||||
ext4_get_inode_flags(ei);
|
||||
raw_inode->i_mode = cpu_to_le16(inode->i_mode);
|
||||
i_uid = i_uid_read(inode);
|
||||
i_gid = i_gid_read(inode);
|
||||
|
Reference in New Issue
Block a user