xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/chrome: chromeos_laptop: drop checks of NULL-safe functions

Browse Source 
No need to check the argument of i2c_unregister_device() and
property_entries_free() because the functions do check it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
This commit is contained in:
Wolfram Sang
2019-08-20 17:34:49 +02:00
committed by Enric Balletbo i Serra
parent 3b81d8bdd9
commit 38d3cfbc95
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/platform/chrome/chromeos_laptop.c
View File

@@ -838,18 +838,14 @@ static void chromeos_laptop_destroy(const struct chromeos_laptop *cros_laptop)
i2c_dev = &cros_laptop->i2c_peripherals[i]; i2c_dev = &cros_laptop->i2c_peripherals[i];
info = &i2c_dev->board_info; info = &i2c_dev->board_info;
if (i2c_dev->client) i2c_unregister_device(i2c_dev->client);
i2c_unregister_device(i2c_dev->client); property_entries_free(info->properties);
if (info->properties)
property_entries_free(info->properties);
} }
for (i = 0; i < cros_laptop->num_acpi_peripherals; i++) { for (i = 0; i < cros_laptop->num_acpi_peripherals; i++) {
acpi_dev = &cros_laptop->acpi_peripherals[i]; acpi_dev = &cros_laptop->acpi_peripherals[i];
if (acpi_dev->properties) property_entries_free(acpi_dev->properties);
property_entries_free(acpi_dev->properties);
} }
kfree(cros_laptop->i2c_peripherals); kfree(cros_laptop->i2c_peripherals);