media: gspca: Convert PDEBUG to gspca_dbg
Use a more typical logging style. The current macro hides the gspca_dev argument so add it to the macro uses instead. Miscellanea: o Add missing '\n' terminations to formats o Realign arguments to open parenthesis o Remove commented out uses of PDEBUG Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:

committed by
Mauro Carvalho Chehab

parent
52173c5f3f
commit
37d5efb019
@@ -75,8 +75,8 @@ static void reg_r(struct gspca_dev *gspca_dev,
|
||||
index,
|
||||
gspca_dev->usb_buf, len,
|
||||
500);
|
||||
PDEBUG(D_USBI, "GET %02x 0000 %04x %02x", req, index,
|
||||
gspca_dev->usb_buf[0]);
|
||||
gspca_dbg(gspca_dev, D_USBI, "GET %02x 0000 %04x %02x\n", req, index,
|
||||
gspca_dev->usb_buf[0]);
|
||||
if (ret < 0) {
|
||||
pr_err("reg_r err %d\n", ret);
|
||||
gspca_dev->usb_err = ret;
|
||||
@@ -93,7 +93,7 @@ static void reg_w(struct gspca_dev *gspca_dev,
|
||||
|
||||
if (gspca_dev->usb_err < 0)
|
||||
return;
|
||||
PDEBUG(D_USBO, "SET %02x %04x %04x", req, value, index);
|
||||
gspca_dbg(gspca_dev, D_USBO, "SET %02x %04x %04x\n", req, value, index);
|
||||
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
|
||||
req,
|
||||
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
|
||||
@@ -116,7 +116,8 @@ static void reg_wb(struct gspca_dev *gspca_dev,
|
||||
|
||||
if (gspca_dev->usb_err < 0)
|
||||
return;
|
||||
PDEBUG(D_USBO, "SET %02x %04x %04x %02x", req, value, index, byte);
|
||||
gspca_dbg(gspca_dev, D_USBO, "SET %02x %04x %04x %02x\n",
|
||||
req, value, index, byte);
|
||||
gspca_dev->usb_buf[0] = byte;
|
||||
ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
|
||||
req,
|
||||
@@ -216,8 +217,8 @@ static int sd_init(struct gspca_dev *gspca_dev)
|
||||
reg_r(gspca_dev, 0x20, 0x0000, 1);
|
||||
reg_r(gspca_dev, 0x20, 0x0000, 5);
|
||||
reg_r(gspca_dev, 0x23, 0x0000, 64);
|
||||
PDEBUG(D_PROBE, "%s%s", &gspca_dev->usb_buf[0x1c],
|
||||
&gspca_dev->usb_buf[0x30]);
|
||||
gspca_dbg(gspca_dev, D_PROBE, "%s%s\n", &gspca_dev->usb_buf[0x1c],
|
||||
&gspca_dev->usb_buf[0x30]);
|
||||
reg_r(gspca_dev, 0x23, 0x0001, 64);
|
||||
return gspca_dev->usb_err;
|
||||
}
|
||||
|
Reference in New Issue
Block a user