USB: uhci: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
此提交包含在:
@@ -590,14 +590,10 @@ static int uhci_start(struct usb_hcd *hcd)
|
||||
init_waitqueue_head(&uhci->waitqh);
|
||||
|
||||
#ifdef UHCI_DEBUG_OPS
|
||||
dentry = debugfs_create_file(hcd->self.bus_name,
|
||||
S_IFREG|S_IRUGO|S_IWUSR, uhci_debugfs_root,
|
||||
uhci, &uhci_debug_operations);
|
||||
if (!dentry) {
|
||||
dev_err(uhci_dev(uhci), "couldn't create uhci debugfs entry\n");
|
||||
return -ENOMEM;
|
||||
}
|
||||
uhci->dentry = dentry;
|
||||
uhci->dentry = debugfs_create_file(hcd->self.bus_name,
|
||||
S_IFREG|S_IRUGO|S_IWUSR,
|
||||
uhci_debugfs_root, uhci,
|
||||
&uhci_debug_operations);
|
||||
#endif
|
||||
|
||||
uhci->frame = dma_zalloc_coherent(uhci_dev(uhci),
|
||||
@@ -882,8 +878,6 @@ static int __init uhci_hcd_init(void)
|
||||
if (!errbuf)
|
||||
goto errbuf_failed;
|
||||
uhci_debugfs_root = debugfs_create_dir("uhci", usb_debug_root);
|
||||
if (!uhci_debugfs_root)
|
||||
goto debug_failed;
|
||||
#endif
|
||||
|
||||
uhci_up_cachep = kmem_cache_create("uhci_urb_priv",
|
||||
@@ -918,7 +912,6 @@ up_failed:
|
||||
#if defined(DEBUG) || defined(CONFIG_DYNAMIC_DEBUG)
|
||||
debugfs_remove(uhci_debugfs_root);
|
||||
|
||||
debug_failed:
|
||||
kfree(errbuf);
|
||||
|
||||
errbuf_failed:
|
||||
|
新增問題並參考
封鎖使用者