drm: Stop accessing encoder->bridge directly
We are about to replace the single-linked bridge list by a double-linked one based on list.h, leading to the suppression of the encoder->bridge field. But before we can do that we must provide a drm_bridge_chain_get_first_bridge() bridge helper and patch all drivers and core helpers to use it instead of directly accessing encoder->bridge. Note that we still have 2 drivers (VC4 and Exynos) manipulating the encoder->bridge field directly because they need to cut the bridge chain in order to control the enable/disable sequence. This is definitely not something we want to encourage, so let's keep those 2 oddities around until we find a better solution. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191203141515.3597631-4-boris.brezillon@collabora.com
This commit is contained in:
@@ -25,6 +25,7 @@
|
||||
|
||||
#include <linux/list.h>
|
||||
#include <linux/ctype.h>
|
||||
#include <drm/drm_encoder.h>
|
||||
#include <drm/drm_mode_object.h>
|
||||
#include <drm/drm_modes.h>
|
||||
|
||||
@@ -422,6 +423,20 @@ drm_bridge_get_next_bridge(struct drm_bridge *bridge)
|
||||
return bridge->next;
|
||||
}
|
||||
|
||||
/**
|
||||
* drm_bridge_chain_get_first_bridge() - Get the first bridge in the chain
|
||||
* @encoder: encoder object
|
||||
*
|
||||
* RETURNS:
|
||||
* the first bridge in the chain, or NULL if @encoder has no bridge attached
|
||||
* to it.
|
||||
*/
|
||||
static inline struct drm_bridge *
|
||||
drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder)
|
||||
{
|
||||
return encoder->bridge;
|
||||
}
|
||||
|
||||
bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge,
|
||||
const struct drm_display_mode *mode,
|
||||
struct drm_display_mode *adjusted_mode);
|
||||
|
Reference in New Issue
Block a user