ipr: Endian / sparse fixes
Some misc fixes for endianness checking with sparse so sparse with endian checking now runs clean. Fixes a minor bug in the process which was uncovered by sparse which would result in unnecessary error recovery for check conditions. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Reviewed-by: Wen Xiong <wenxiong@linux.vnet.ibm.com> Signed-off-by: James Bottomley <JBottomley@Odin.com>
This commit is contained in:

committed by
James Bottomley

parent
bb8647e86e
commit
359d96e73c
@@ -1165,7 +1165,8 @@ static void ipr_init_res_entry(struct ipr_resource_entry *res,
|
||||
|
||||
if (ioa_cfg->sis64) {
|
||||
proto = cfgtew->u.cfgte64->proto;
|
||||
res->res_flags = cfgtew->u.cfgte64->res_flags;
|
||||
res->flags = be16_to_cpu(cfgtew->u.cfgte64->flags);
|
||||
res->res_flags = be16_to_cpu(cfgtew->u.cfgte64->res_flags);
|
||||
res->qmodel = IPR_QUEUEING_MODEL64(res);
|
||||
res->type = cfgtew->u.cfgte64->res_type;
|
||||
|
||||
@@ -1313,8 +1314,8 @@ static void ipr_update_res_entry(struct ipr_resource_entry *res,
|
||||
int new_path = 0;
|
||||
|
||||
if (res->ioa_cfg->sis64) {
|
||||
res->flags = cfgtew->u.cfgte64->flags;
|
||||
res->res_flags = cfgtew->u.cfgte64->res_flags;
|
||||
res->flags = be16_to_cpu(cfgtew->u.cfgte64->flags);
|
||||
res->res_flags = be16_to_cpu(cfgtew->u.cfgte64->res_flags);
|
||||
res->type = cfgtew->u.cfgte64->res_type;
|
||||
|
||||
memcpy(&res->std_inq_data, &cfgtew->u.cfgte64->std_inq_data,
|
||||
@@ -1900,7 +1901,7 @@ static void ipr_log_array_error(struct ipr_ioa_cfg *ioa_cfg,
|
||||
* Return value:
|
||||
* none
|
||||
**/
|
||||
static void ipr_log_hex_data(struct ipr_ioa_cfg *ioa_cfg, u32 *data, int len)
|
||||
static void ipr_log_hex_data(struct ipr_ioa_cfg *ioa_cfg, __be32 *data, int len)
|
||||
{
|
||||
int i;
|
||||
|
||||
@@ -2270,7 +2271,7 @@ static void ipr_log_fabric_error(struct ipr_ioa_cfg *ioa_cfg,
|
||||
((unsigned long)fabric + be16_to_cpu(fabric->length));
|
||||
}
|
||||
|
||||
ipr_log_hex_data(ioa_cfg, (u32 *)fabric, add_len);
|
||||
ipr_log_hex_data(ioa_cfg, (__be32 *)fabric, add_len);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -2364,7 +2365,7 @@ static void ipr_log_sis64_fabric_error(struct ipr_ioa_cfg *ioa_cfg,
|
||||
((unsigned long)fabric + be16_to_cpu(fabric->length));
|
||||
}
|
||||
|
||||
ipr_log_hex_data(ioa_cfg, (u32 *)fabric, add_len);
|
||||
ipr_log_hex_data(ioa_cfg, (__be32 *)fabric, add_len);
|
||||
}
|
||||
|
||||
/**
|
||||
|
Reference in New Issue
Block a user