mm/vmscan: drop may_writepage and classzone_idx from direct reclaim begin template
There are three tracepoints using this template, which are mm_vmscan_direct_reclaim_begin, mm_vmscan_memcg_reclaim_begin, mm_vmscan_memcg_softlimit_reclaim_begin. Regarding mm_vmscan_direct_reclaim_begin, sc.may_writepage is !laptop_mode, that's a static setting, and reclaim_idx is derived from gfp_mask which is already show in this tracepoint. Regarding mm_vmscan_memcg_reclaim_begin, may_writepage is !laptop_mode too, and reclaim_idx is (MAX_NR_ZONES-1), which are both static value. mm_vmscan_memcg_softlimit_reclaim_begin is the same with mm_vmscan_memcg_reclaim_begin. So we can drop them all. Link: http://lkml.kernel.org/r/1553736322-32235-1-git-send-email-laoar.shao@gmail.com Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
024eee0e83
commit
3481c37ffa
14
mm/vmscan.c
14
mm/vmscan.c
@@ -3174,10 +3174,7 @@ unsigned long try_to_free_pages(struct zonelist *zonelist, int order,
|
||||
if (throttle_direct_reclaim(sc.gfp_mask, zonelist, nodemask))
|
||||
return 1;
|
||||
|
||||
trace_mm_vmscan_direct_reclaim_begin(order,
|
||||
sc.may_writepage,
|
||||
sc.gfp_mask,
|
||||
sc.reclaim_idx);
|
||||
trace_mm_vmscan_direct_reclaim_begin(order, sc.gfp_mask);
|
||||
|
||||
nr_reclaimed = do_try_to_free_pages(zonelist, &sc);
|
||||
|
||||
@@ -3208,9 +3205,7 @@ unsigned long mem_cgroup_shrink_node(struct mem_cgroup *memcg,
|
||||
(GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK);
|
||||
|
||||
trace_mm_vmscan_memcg_softlimit_reclaim_begin(sc.order,
|
||||
sc.may_writepage,
|
||||
sc.gfp_mask,
|
||||
sc.reclaim_idx);
|
||||
sc.gfp_mask);
|
||||
|
||||
/*
|
||||
* NOTE: Although we can get the priority field, using it
|
||||
@@ -3259,10 +3254,7 @@ unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg,
|
||||
|
||||
zonelist = &NODE_DATA(nid)->node_zonelists[ZONELIST_FALLBACK];
|
||||
|
||||
trace_mm_vmscan_memcg_reclaim_begin(0,
|
||||
sc.may_writepage,
|
||||
sc.gfp_mask,
|
||||
sc.reclaim_idx);
|
||||
trace_mm_vmscan_memcg_reclaim_begin(0, sc.gfp_mask);
|
||||
|
||||
psi_memstall_enter(&pflags);
|
||||
noreclaim_flag = memalloc_noreclaim_save();
|
||||
|
Reference in New Issue
Block a user