mm/vmscan: drop may_writepage and classzone_idx from direct reclaim begin template
There are three tracepoints using this template, which are mm_vmscan_direct_reclaim_begin, mm_vmscan_memcg_reclaim_begin, mm_vmscan_memcg_softlimit_reclaim_begin. Regarding mm_vmscan_direct_reclaim_begin, sc.may_writepage is !laptop_mode, that's a static setting, and reclaim_idx is derived from gfp_mask which is already show in this tracepoint. Regarding mm_vmscan_memcg_reclaim_begin, may_writepage is !laptop_mode too, and reclaim_idx is (MAX_NR_ZONES-1), which are both static value. mm_vmscan_memcg_softlimit_reclaim_begin is the same with mm_vmscan_memcg_reclaim_begin. So we can drop them all. Link: http://lkml.kernel.org/r/1553736322-32235-1-git-send-email-laoar.shao@gmail.com Signed-off-by: Yafang Shao <laoar.shao@gmail.com> Acked-by: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
024eee0e83
commit
3481c37ffa
@@ -106,51 +106,45 @@ TRACE_EVENT(mm_vmscan_wakeup_kswapd,
|
||||
|
||||
DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_begin_template,
|
||||
|
||||
TP_PROTO(int order, int may_writepage, gfp_t gfp_flags, int classzone_idx),
|
||||
TP_PROTO(int order, gfp_t gfp_flags),
|
||||
|
||||
TP_ARGS(order, may_writepage, gfp_flags, classzone_idx),
|
||||
TP_ARGS(order, gfp_flags),
|
||||
|
||||
TP_STRUCT__entry(
|
||||
__field( int, order )
|
||||
__field( int, may_writepage )
|
||||
__field( gfp_t, gfp_flags )
|
||||
__field( int, classzone_idx )
|
||||
),
|
||||
|
||||
TP_fast_assign(
|
||||
__entry->order = order;
|
||||
__entry->may_writepage = may_writepage;
|
||||
__entry->gfp_flags = gfp_flags;
|
||||
__entry->classzone_idx = classzone_idx;
|
||||
),
|
||||
|
||||
TP_printk("order=%d may_writepage=%d gfp_flags=%s classzone_idx=%d",
|
||||
TP_printk("order=%d gfp_flags=%s",
|
||||
__entry->order,
|
||||
__entry->may_writepage,
|
||||
show_gfp_flags(__entry->gfp_flags),
|
||||
__entry->classzone_idx)
|
||||
show_gfp_flags(__entry->gfp_flags))
|
||||
);
|
||||
|
||||
DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_direct_reclaim_begin,
|
||||
|
||||
TP_PROTO(int order, int may_writepage, gfp_t gfp_flags, int classzone_idx),
|
||||
TP_PROTO(int order, gfp_t gfp_flags),
|
||||
|
||||
TP_ARGS(order, may_writepage, gfp_flags, classzone_idx)
|
||||
TP_ARGS(order, gfp_flags)
|
||||
);
|
||||
|
||||
#ifdef CONFIG_MEMCG
|
||||
DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_reclaim_begin,
|
||||
|
||||
TP_PROTO(int order, int may_writepage, gfp_t gfp_flags, int classzone_idx),
|
||||
TP_PROTO(int order, gfp_t gfp_flags),
|
||||
|
||||
TP_ARGS(order, may_writepage, gfp_flags, classzone_idx)
|
||||
TP_ARGS(order, gfp_flags)
|
||||
);
|
||||
|
||||
DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_softlimit_reclaim_begin,
|
||||
|
||||
TP_PROTO(int order, int may_writepage, gfp_t gfp_flags, int classzone_idx),
|
||||
TP_PROTO(int order, gfp_t gfp_flags),
|
||||
|
||||
TP_ARGS(order, may_writepage, gfp_flags, classzone_idx)
|
||||
TP_ARGS(order, gfp_flags)
|
||||
);
|
||||
#endif /* CONFIG_MEMCG */
|
||||
|
||||
|
Reference in New Issue
Block a user