coallocate socket_wq with socket itself
socket->wq is assign-once, set when we are initializing both struct socket it's in and struct socket_wq it points to. As the matter of fact, the only reason for separate allocation was the ability to RCU-delay freeing of socket_wq. RCU-delaying the freeing of socket itself gets rid of that need, so we can just fold struct socket_wq into the end of struct socket and simplify the life both for sock_alloc_inode() (one allocation instead of two) and for tun/tap oddballs, where we used to embed struct socket and struct socket_wq into the same structure (now - embedding just the struct socket). Note that reference to struct socket_wq in struct sock does remain a reference - that's unchanged. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
@@ -520,8 +520,7 @@ static int tap_open(struct inode *inode, struct file *file)
|
||||
goto err;
|
||||
}
|
||||
|
||||
RCU_INIT_POINTER(q->sock.wq, &q->wq);
|
||||
init_waitqueue_head(&q->wq.wait);
|
||||
init_waitqueue_head(&q->sock.wq.wait);
|
||||
q->sock.type = SOCK_RAW;
|
||||
q->sock.state = SS_CONNECTED;
|
||||
q->sock.file = file;
|
||||
@@ -579,7 +578,7 @@ static __poll_t tap_poll(struct file *file, poll_table *wait)
|
||||
goto out;
|
||||
|
||||
mask = 0;
|
||||
poll_wait(file, &q->wq.wait, wait);
|
||||
poll_wait(file, &q->sock.wq.wait, wait);
|
||||
|
||||
if (!ptr_ring_empty(&q->ring))
|
||||
mask |= EPOLLIN | EPOLLRDNORM;
|
||||
|
Reference in New Issue
Block a user