libceph: introduce ceph_pagelist_alloc()
struct ceph_pagelist cannot be embedded into anything else because it has its own refcount. Merge allocation and initialization together. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
@@ -776,12 +776,10 @@ int osd_req_op_cls_init(struct ceph_osd_request *osd_req, unsigned int which,
|
||||
|
||||
op = _osd_req_op_init(osd_req, which, CEPH_OSD_OP_CALL, 0);
|
||||
|
||||
pagelist = kmalloc(sizeof (*pagelist), GFP_NOFS);
|
||||
pagelist = ceph_pagelist_alloc(GFP_NOFS);
|
||||
if (!pagelist)
|
||||
return -ENOMEM;
|
||||
|
||||
ceph_pagelist_init(pagelist);
|
||||
|
||||
op->cls.class_name = class;
|
||||
size = strlen(class);
|
||||
BUG_ON(size > (size_t) U8_MAX);
|
||||
@@ -814,12 +812,10 @@ int osd_req_op_xattr_init(struct ceph_osd_request *osd_req, unsigned int which,
|
||||
|
||||
BUG_ON(opcode != CEPH_OSD_OP_SETXATTR && opcode != CEPH_OSD_OP_CMPXATTR);
|
||||
|
||||
pagelist = kmalloc(sizeof(*pagelist), GFP_NOFS);
|
||||
pagelist = ceph_pagelist_alloc(GFP_NOFS);
|
||||
if (!pagelist)
|
||||
return -ENOMEM;
|
||||
|
||||
ceph_pagelist_init(pagelist);
|
||||
|
||||
payload_len = strlen(name);
|
||||
op->xattr.name_len = payload_len;
|
||||
ceph_pagelist_append(pagelist, name, payload_len);
|
||||
@@ -4598,11 +4594,10 @@ static int osd_req_op_notify_ack_init(struct ceph_osd_request *req, int which,
|
||||
|
||||
op = _osd_req_op_init(req, which, CEPH_OSD_OP_NOTIFY_ACK, 0);
|
||||
|
||||
pl = kmalloc(sizeof(*pl), GFP_NOIO);
|
||||
pl = ceph_pagelist_alloc(GFP_NOIO);
|
||||
if (!pl)
|
||||
return -ENOMEM;
|
||||
|
||||
ceph_pagelist_init(pl);
|
||||
ret = ceph_pagelist_encode_64(pl, notify_id);
|
||||
ret |= ceph_pagelist_encode_64(pl, cookie);
|
||||
if (payload) {
|
||||
@@ -4669,11 +4664,10 @@ static int osd_req_op_notify_init(struct ceph_osd_request *req, int which,
|
||||
op = _osd_req_op_init(req, which, CEPH_OSD_OP_NOTIFY, 0);
|
||||
op->notify.cookie = cookie;
|
||||
|
||||
pl = kmalloc(sizeof(*pl), GFP_NOIO);
|
||||
pl = ceph_pagelist_alloc(GFP_NOIO);
|
||||
if (!pl)
|
||||
return -ENOMEM;
|
||||
|
||||
ceph_pagelist_init(pl);
|
||||
ret = ceph_pagelist_encode_32(pl, 1); /* prot_ver */
|
||||
ret |= ceph_pagelist_encode_32(pl, timeout);
|
||||
ret |= ceph_pagelist_encode_32(pl, payload_len);
|
||||
|
@@ -6,6 +6,26 @@
|
||||
#include <linux/highmem.h>
|
||||
#include <linux/ceph/pagelist.h>
|
||||
|
||||
struct ceph_pagelist *ceph_pagelist_alloc(gfp_t gfp_flags)
|
||||
{
|
||||
struct ceph_pagelist *pl;
|
||||
|
||||
pl = kmalloc(sizeof(*pl), gfp_flags);
|
||||
if (!pl)
|
||||
return NULL;
|
||||
|
||||
INIT_LIST_HEAD(&pl->head);
|
||||
pl->mapped_tail = NULL;
|
||||
pl->length = 0;
|
||||
pl->room = 0;
|
||||
INIT_LIST_HEAD(&pl->free_list);
|
||||
pl->num_pages_free = 0;
|
||||
refcount_set(&pl->refcnt, 1);
|
||||
|
||||
return pl;
|
||||
}
|
||||
EXPORT_SYMBOL(ceph_pagelist_alloc);
|
||||
|
||||
static void ceph_pagelist_unmap_tail(struct ceph_pagelist *pl)
|
||||
{
|
||||
if (pl->mapped_tail) {
|
||||
|
Reference in New Issue
Block a user