perf intel-pt/bts: Tidy instruction buffer size usage
Tidy instruction buffer size usage in preparation for copying the instruction bytes onto samples. The instruction buffer is presently used for debugging, so rename its size macro from INTEL_PT_INSN_DBG_BUF_SZ to INTEL_PT_INSN_BUF_SZ, and use it everywhere. Note that the maximum instruction size is 15 which is a less efficient size to copy than 16, which is why a separate buffer size is used. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: Andi Kleen <ak@linux.intel.com> Link: http://lkml.kernel.org/r/1475847747-30994-2-git-send-email-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:

committed by
Arnaldo Carvalho de Melo

parent
e9c848928a
commit
32f98aab75
@@ -319,15 +319,12 @@ static int intel_bts_get_next_insn(struct intel_bts_queue *btsq, u64 ip)
|
||||
struct machine *machine = btsq->bts->machine;
|
||||
struct thread *thread;
|
||||
struct addr_location al;
|
||||
unsigned char buf[1024];
|
||||
size_t bufsz;
|
||||
unsigned char buf[INTEL_PT_INSN_BUF_SZ];
|
||||
ssize_t len;
|
||||
int x86_64;
|
||||
uint8_t cpumode;
|
||||
int err = -1;
|
||||
|
||||
bufsz = intel_pt_insn_max_size();
|
||||
|
||||
if (machine__kernel_ip(machine, ip))
|
||||
cpumode = PERF_RECORD_MISC_KERNEL;
|
||||
else
|
||||
@@ -341,7 +338,8 @@ static int intel_bts_get_next_insn(struct intel_bts_queue *btsq, u64 ip)
|
||||
if (!al.map || !al.map->dso)
|
||||
goto out_put;
|
||||
|
||||
len = dso__data_read_addr(al.map->dso, al.map, machine, ip, buf, bufsz);
|
||||
len = dso__data_read_addr(al.map->dso, al.map, machine, ip, buf,
|
||||
INTEL_PT_INSN_BUF_SZ);
|
||||
if (len <= 0)
|
||||
goto out_put;
|
||||
|
||||
|
Reference in New Issue
Block a user