lightnvm: pblk: remove internal IO timeout
Currently during pblk padding, there is internal IO timeout introduced, which is smaller than default NVMe timeout. This can lead to various use-after-free issues. Since in case of any IO timeouts NVMe and block layer will handle timeout by themselves and report it back to use, there is no need to keep this internal timeout in pblk. Signed-off-by: Igor Konopko <igor.j.konopko@intel.com> Signed-off-by: Matias Bjørling <mb@lightnvm.io> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Этот коммит содержится в:

коммит произвёл
Jens Axboe

родитель
1fc3b30569
Коммит
32ac0fa3af
@@ -290,12 +290,7 @@ next_pad_rq:
|
||||
|
||||
fail_complete:
|
||||
kref_put(&pad_rq->ref, pblk_recov_complete);
|
||||
|
||||
if (!wait_for_completion_io_timeout(&pad_rq->wait,
|
||||
msecs_to_jiffies(PBLK_COMMAND_TIMEOUT_MS))) {
|
||||
pblk_err(pblk, "pad write timed out\n");
|
||||
ret = -ETIME;
|
||||
}
|
||||
wait_for_completion(&pad_rq->wait);
|
||||
|
||||
if (!pblk_line_is_full(line))
|
||||
pblk_err(pblk, "corrupted padded line: %d\n", line->id);
|
||||
|
Ссылка в новой задаче
Block a user