x86-32, hibernate: Switch to original page table after resumed
After all the pages are restored to previous address, the page table switches back to current swapper_pg_dir. However the swapper_pg_dir currently in used might not be consistent with previous page table, which might cause issue after resume. Fix this issue by switching to original page table after resume, and the address of the original page table is saved in the hibernation image header. Move the manipulation of restore_cr3 into common code blocks. Signed-off-by: Zhimin Gu <kookoo.gu@intel.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Chen Yu <yu.c.chen@intel.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:

committed by
Rafael J. Wysocki

parent
0b0a6b1f76
commit
32aa276437
@@ -25,6 +25,10 @@ ENTRY(swsusp_arch_suspend)
|
||||
pushfl
|
||||
popl saved_context_eflags
|
||||
|
||||
/* save cr3 */
|
||||
movl %cr3, %eax
|
||||
movl %eax, restore_cr3
|
||||
|
||||
FRAME_BEGIN
|
||||
call swsusp_save
|
||||
FRAME_END
|
||||
@@ -32,6 +36,8 @@ ENTRY(swsusp_arch_suspend)
|
||||
ENDPROC(swsusp_arch_suspend)
|
||||
|
||||
ENTRY(restore_image)
|
||||
movl restore_cr3, %ebp
|
||||
|
||||
movl mmu_cr4_features, %ecx
|
||||
movl temp_pgt, %eax
|
||||
movl %eax, %cr3
|
||||
@@ -66,9 +72,7 @@ done:
|
||||
.align PAGE_SIZE
|
||||
ENTRY(restore_registers)
|
||||
/* go back to the original page tables */
|
||||
movl $swapper_pg_dir, %eax
|
||||
subl $__PAGE_OFFSET, %eax
|
||||
movl %eax, %cr3
|
||||
movl %ebp, %cr3
|
||||
movl mmu_cr4_features, %ecx
|
||||
jecxz 1f # cr4 Pentium and higher, skip if zero
|
||||
movl %ecx, %cr4; # turn PGE back on
|
||||
|
Reference in New Issue
Block a user