bonding: fix multiple 3ad mode sysfs race conditions
When bond_3ad_get_active_agg_info() is used in all show_ad_ functions it is not protected against slave manipulation and since it walks over the slaves and uses them, this can easily result in NULL pointer dereference or use of freed memory. Both the new wrapper and the internal function are exported to the bonding as they're needed in different places. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
5a5c5fd48e
commit
318debd897
@@ -130,7 +130,7 @@ static void bond_info_show_master(struct seq_file *seq)
|
||||
seq_printf(seq, "Aggregator selection policy (ad_select): %s\n",
|
||||
ad_select_tbl[bond->params.ad_select].modename);
|
||||
|
||||
if (bond_3ad_get_active_agg_info(bond, &ad_info)) {
|
||||
if (__bond_3ad_get_active_agg_info(bond, &ad_info)) {
|
||||
seq_printf(seq, "bond %s has no active aggregator\n",
|
||||
bond->dev->name);
|
||||
} else {
|
||||
|
Reference in New Issue
Block a user