xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: gpio-vf610: do not touch other bits when set the target bit

Browse Source 
[ Upstream commit 9bf3ac466faa83d51a8fe9212131701e58fdef74 ]

For gpio controller contain register PDDR, when set one target bit,
current logic will clear all other bits, this is wrong. Use operator
'|=' to fix it.

Fixes: 659d8a6231 ("gpio: vf610: add imx7ulp support")
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Haibo Chen
2022-05-11 10:15:04 +08:00
committed by Greg Kroah-Hartman
parent ea8a9cb4a7
commit 30d4721fec
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpio/gpio-vf610.c
View File

@@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio,
{ {
struct vf610_gpio_port *port = gpiochip_get_data(chip); struct vf610_gpio_port *port = gpiochip_get_data(chip);
unsigned long mask = BIT(gpio); unsigned long mask = BIT(gpio);
u32 val;
if (port->sdata && port->sdata->have_paddr) if (port->sdata && port->sdata->have_paddr) {
vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR); val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR);
val |= mask;
vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR);
}
vf610_gpio_set(chip, gpio, value); vf610_gpio_set(chip, gpio, value);