xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: mvpp2: Put fwnode in error case during ->probe()

Browse Source 
[ Upstream commit 71f0891c84dfdc448736082ab0a00acd29853896 ]

In each iteration fwnode_for_each_available_child_node() bumps a reference
counting of a loop variable followed by dropping in on a next iteration,

Since in error case the loop is broken, we have to drop a reference count
by ourselves. Do it for port_fwnode in error case during ->probe().

Fixes: 248122212f ("net: mvpp2: use device_*/fwnode_* APIs instead of of_*")
Cc: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Andy Shevchenko
2021-05-10 12:58:05 +03:00
committed by Greg Kroah-Hartman
parent b3fecbf60e
commit 2f9f23c43a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
View File

@@ -7045,6 +7045,8 @@ static int mvpp2_probe(struct platform_device *pdev)
return 0; return 0;
err_port_probe: err_port_probe:
fwnode_handle_put(port_fwnode);
i = 0; i = 0;
fwnode_for_each_available_child_node(fwnode, port_fwnode) { fwnode_for_each_available_child_node(fwnode, port_fwnode) {
if (priv->port_list[i]) if (priv->port_list[i])