xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

genetlink: remove superfluous assignment

Browse Source 
the local variable ops and n_ops were just read out from family,
and not changed, hence no need to assign back.

Validation functions should operate on const parameters and not
change anything.

Signed-off-by: Cheng Renquan <crquan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Denis ChengRq
2014-06-02 01:18:01 -07:00
committed by David S. Miller
parent 96b2e73c54
commit 2f91abd451
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/netlink/genetlink.c
View File

@@ -317,7 +317,7 @@ static void genl_unregister_mc_groups(struct genl_family *family)
} }
} }
static int genl_validate_ops(struct genl_family *family) static int genl_validate_ops(const struct genl_family *family)
{ {
const struct genl_ops *ops = family->ops; const struct genl_ops *ops = family->ops;
unsigned int n_ops = family->n_ops; unsigned int n_ops = family->n_ops;
@@ -337,10 +337,6 @@ static int genl_validate_ops(struct genl_family *family)
return -EINVAL; return -EINVAL;
} }
/* family is not registered yet, so no locking needed */
family->ops = ops;
family->n_ops = n_ops;
return 0; return 0;
} }