TTY: remove re-assignments to tty_driver members
All num, magic and owner are set by alloc_tty_driver. No need to re-set them on each allocation site. pti driver sets something different to what it passes to alloc_tty_driver. It is not a bug, since we don't use the lines parameter in any way. Anyway this is fixed, and now we do the right thing. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Acked-by: Tilman Schmidt <tilman@imap.cc> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
这个提交包含在:
@@ -669,17 +669,15 @@ EXPORT_SYMBOL_GPL(gigaset_if_receive);
|
||||
void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname,
|
||||
const char *devname)
|
||||
{
|
||||
unsigned minors = drv->minors;
|
||||
int ret;
|
||||
struct tty_driver *tty;
|
||||
|
||||
drv->have_tty = 0;
|
||||
|
||||
drv->tty = tty = alloc_tty_driver(minors);
|
||||
drv->tty = tty = alloc_tty_driver(drv->minors);
|
||||
if (tty == NULL)
|
||||
goto enomem;
|
||||
|
||||
tty->magic = TTY_DRIVER_MAGIC,
|
||||
tty->type = TTY_DRIVER_TYPE_SERIAL,
|
||||
tty->subtype = SERIAL_TYPE_NORMAL,
|
||||
tty->flags = TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV;
|
||||
@@ -687,9 +685,6 @@ void gigaset_if_initdriver(struct gigaset_driver *drv, const char *procname,
|
||||
tty->driver_name = procname;
|
||||
tty->name = devname;
|
||||
tty->minor_start = drv->minor;
|
||||
tty->num = drv->minors;
|
||||
|
||||
tty->owner = THIS_MODULE;
|
||||
|
||||
tty->init_termios = tty_std_termios;
|
||||
tty->init_termios.c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL;
|
||||
|
在新工单中引用
屏蔽一个用户