earlycon: Use common framework for earlycon declarations
Use a single common table of struct earlycon_id for both command line and devicetree. Re-define OF_EARLYCON_DECLARE() macro to instance a unique earlycon declaration (the declaration is only guaranteed to be unique within a compilation unit; separate compilation units must still use unique earlycon names). The semantics of OF_EARLYCON_DECLARE() is different; it declares an earlycon which can matched either on the command line or by devicetree. EARLYCON_DECLARE() is semantically unchanged; it declares an earlycon which is matched by command line only. Remove redundant instances of EARLYCON_DECLARE(). This enables all earlycons to properly initialize struct console with the appropriate name and index, which improves diagnostics and enables direct earlycon-to-console handoff. Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
8477614d9f
commit
2eaa790989
@@ -796,14 +796,13 @@ static inline void early_init_dt_check_for_initrd(unsigned long node)
|
||||
#endif /* CONFIG_BLK_DEV_INITRD */
|
||||
|
||||
#ifdef CONFIG_SERIAL_EARLYCON
|
||||
extern struct of_device_id __earlycon_of_table[];
|
||||
|
||||
static int __init early_init_dt_scan_chosen_serial(void)
|
||||
{
|
||||
int offset;
|
||||
const char *p;
|
||||
int l;
|
||||
const struct of_device_id *match = __earlycon_of_table;
|
||||
const struct earlycon_id *match;
|
||||
const void *fdt = initial_boot_params;
|
||||
|
||||
offset = fdt_path_offset(fdt, "/chosen");
|
||||
@@ -826,19 +825,20 @@ static int __init early_init_dt_scan_chosen_serial(void)
|
||||
if (offset < 0)
|
||||
return -ENODEV;
|
||||
|
||||
while (match->compatible[0]) {
|
||||
for (match = __earlycon_table; match < __earlycon_table_end; match++) {
|
||||
u64 addr;
|
||||
|
||||
if (fdt_node_check_compatible(fdt, offset, match->compatible)) {
|
||||
match++;
|
||||
if (!match->compatible[0])
|
||||
continue;
|
||||
|
||||
if (fdt_node_check_compatible(fdt, offset, match->compatible))
|
||||
continue;
|
||||
}
|
||||
|
||||
addr = fdt_translate_address(fdt, offset);
|
||||
if (addr == OF_BAD_ADDR)
|
||||
return -ENXIO;
|
||||
|
||||
of_setup_earlycon(addr, match->data);
|
||||
of_setup_earlycon(addr, match->setup);
|
||||
return 0;
|
||||
}
|
||||
return -ENODEV;
|
||||
|
Reference in New Issue
Block a user