drivers/net: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a, b) + ether_addr_equal(a, b) @@ expression a,b; @@ - compare_ether_addr(a, b) + !ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) == 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) != 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) == 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) != 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !!ether_addr_equal(a, b) + ether_addr_equal(a, b) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
39f1d94d30
commit
2e42e4747e
@@ -1023,7 +1023,7 @@ static int efx_ethtool_set_class_rule(struct efx_nic *efx,
|
||||
return -EINVAL;
|
||||
|
||||
/* Is it a default UC or MC filter? */
|
||||
if (!compare_ether_addr(mac_mask->h_dest, mac_addr_mc_mask) &&
|
||||
if (ether_addr_equal(mac_mask->h_dest, mac_addr_mc_mask) &&
|
||||
vlan_tag_mask == 0) {
|
||||
if (is_multicast_ether_addr(mac_entry->h_dest))
|
||||
rc = efx_filter_set_mc_def(&spec);
|
||||
|
Reference in New Issue
Block a user