TTY: switch tty_flip_buffer_push
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. Now, the one where most of tty_port_tty_get gets removed: tty_flip_buffer_push. IOW we also closed all the races in drivers not using tty_port_tty_get at all yet. Also we move tty_flip_buffer_push declaration from include/linux/tty.h to include/linux/tty_flip.h to all others while we are changing it anyway. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
d6c53c0e9b
commit
2e124b4a39
@@ -899,7 +899,6 @@ static void mos7720_bulk_in_callback(struct urb *urb)
|
||||
int retval;
|
||||
unsigned char *data ;
|
||||
struct usb_serial_port *port;
|
||||
struct tty_struct *tty;
|
||||
int status = urb->status;
|
||||
|
||||
if (status) {
|
||||
@@ -913,12 +912,10 @@ static void mos7720_bulk_in_callback(struct urb *urb)
|
||||
|
||||
data = urb->transfer_buffer;
|
||||
|
||||
tty = tty_port_tty_get(&port->port);
|
||||
if (tty && urb->actual_length) {
|
||||
if (urb->actual_length) {
|
||||
tty_insert_flip_string(&port->port, data, urb->actual_length);
|
||||
tty_flip_buffer_push(tty);
|
||||
tty_flip_buffer_push(&port->port);
|
||||
}
|
||||
tty_kref_put(tty);
|
||||
|
||||
if (port->read_urb->status != -EINPROGRESS) {
|
||||
retval = usb_submit_urb(port->read_urb, GFP_ATOMIC);
|
||||
|
Reference in New Issue
Block a user