TTY: switch tty_flip_buffer_push
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. Now, the one where most of tty_port_tty_get gets removed: tty_flip_buffer_push. IOW we also closed all the races in drivers not using tty_port_tty_get at all yet. Also we move tty_flip_buffer_push declaration from include/linux/tty.h to include/linux/tty_flip.h to all others while we are changing it anyway. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
d6c53c0e9b
commit
2e124b4a39
@@ -181,17 +181,17 @@ static struct sunhv_ops bywrite_ops = {
|
||||
|
||||
static struct sunhv_ops *sunhv_ops = &bychar_ops;
|
||||
|
||||
static struct tty_struct *receive_chars(struct uart_port *port)
|
||||
static struct tty_port *receive_chars(struct uart_port *port)
|
||||
{
|
||||
struct tty_struct *tty = NULL;
|
||||
struct tty_port *tport = NULL;
|
||||
|
||||
if (port->state != NULL) /* Unopened serial console */
|
||||
tty = port->state->port.tty;
|
||||
tport = &port->state->port;
|
||||
|
||||
if (sunhv_ops->receive_chars(port))
|
||||
sun_do_break();
|
||||
|
||||
return tty;
|
||||
return tport;
|
||||
}
|
||||
|
||||
static void transmit_chars(struct uart_port *port)
|
||||
@@ -214,16 +214,16 @@ static void transmit_chars(struct uart_port *port)
|
||||
static irqreturn_t sunhv_interrupt(int irq, void *dev_id)
|
||||
{
|
||||
struct uart_port *port = dev_id;
|
||||
struct tty_struct *tty;
|
||||
struct tty_port *tport;
|
||||
unsigned long flags;
|
||||
|
||||
spin_lock_irqsave(&port->lock, flags);
|
||||
tty = receive_chars(port);
|
||||
tport = receive_chars(port);
|
||||
transmit_chars(port);
|
||||
spin_unlock_irqrestore(&port->lock, flags);
|
||||
|
||||
if (tty)
|
||||
tty_flip_buffer_push(tty);
|
||||
if (tport)
|
||||
tty_flip_buffer_push(tport);
|
||||
|
||||
return IRQ_HANDLED;
|
||||
}
|
||||
|
Reference in New Issue
Block a user