TTY: switch tty_flip_buffer_push
Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. Now, the one where most of tty_port_tty_get gets removed: tty_flip_buffer_push. IOW we also closed all the races in drivers not using tty_port_tty_get at all yet. Also we move tty_flip_buffer_push declaration from include/linux/tty.h to include/linux/tty_flip.h to all others while we are changing it anyway. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
d6c53c0e9b
commit
2e124b4a39
@@ -381,7 +381,6 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
|
||||
static void sdio_uart_receive_chars(struct sdio_uart_port *port,
|
||||
unsigned int *status)
|
||||
{
|
||||
struct tty_struct *tty = tty_port_tty_get(&port->port);
|
||||
unsigned int ch, flag;
|
||||
int max_count = 256;
|
||||
|
||||
@@ -418,24 +417,19 @@ static void sdio_uart_receive_chars(struct sdio_uart_port *port,
|
||||
}
|
||||
|
||||
if ((*status & port->ignore_status_mask & ~UART_LSR_OE) == 0)
|
||||
if (tty)
|
||||
tty_insert_flip_char(&port->port, ch, flag);
|
||||
tty_insert_flip_char(&port->port, ch, flag);
|
||||
|
||||
/*
|
||||
* Overrun is special. Since it's reported immediately,
|
||||
* it doesn't affect the current character.
|
||||
*/
|
||||
if (*status & ~port->ignore_status_mask & UART_LSR_OE)
|
||||
if (tty)
|
||||
tty_insert_flip_char(&port->port, 0,
|
||||
TTY_OVERRUN);
|
||||
tty_insert_flip_char(&port->port, 0, TTY_OVERRUN);
|
||||
|
||||
*status = sdio_in(port, UART_LSR);
|
||||
} while ((*status & UART_LSR_DR) && (max_count-- > 0));
|
||||
if (tty) {
|
||||
tty_flip_buffer_push(tty);
|
||||
tty_kref_put(tty);
|
||||
}
|
||||
|
||||
tty_flip_buffer_push(&port->port);
|
||||
}
|
||||
|
||||
static void sdio_uart_transmit_chars(struct sdio_uart_port *port)
|
||||
|
Reference in New Issue
Block a user