[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer. Add new member variables - bytesused, length, offset, userptr, fd, data_offset - to struct vb2_plane in order to cover all information of v4l2_plane. struct vb2_plane { <snip> unsigned int bytesused; unsigned int length; union { unsigned int offset; unsigned long userptr; int fd; } m; unsigned int data_offset; } Replace v4l2_buf with new member variables - index, type, memory - which are common fields for buffer management. struct vb2_buffer { <snip> unsigned int index; unsigned int type; unsigned int memory; unsigned int num_planes; struct vb2_plane planes[VIDEO_MAX_PLANES]; <snip> }; v4l2 specific fields - flags, field, timestamp, timecode, sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c struct vb2_v4l2_buffer { struct vb2_buffer vb2_buf; __u32 flags; __u32 field; struct timeval timestamp; struct v4l2_timecode timecode; __u32 sequence; }; Signed-off-by: Junghak Sung <jh1009.sung@samsung.com> Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> Acked-by: Inki Dae <inki.dae@samsung.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
这个提交包含在:
@@ -306,7 +306,7 @@ static void usbtv_image_chunk(struct usbtv *usbtv, __be32 *chunk)
|
||||
|
||||
/* First available buffer. */
|
||||
buf = list_first_entry(&usbtv->bufs, struct usbtv_buf, list);
|
||||
frame = vb2_plane_vaddr(&buf->vb, 0);
|
||||
frame = vb2_plane_vaddr(&buf->vb.vb2_buf, 0);
|
||||
|
||||
/* Copy the chunk data. */
|
||||
usbtv_chunk_to_vbuf(frame, &chunk[1], chunk_no, odd);
|
||||
@@ -314,17 +314,17 @@ static void usbtv_image_chunk(struct usbtv *usbtv, __be32 *chunk)
|
||||
|
||||
/* Last chunk in a frame, signalling an end */
|
||||
if (odd && chunk_no == usbtv->n_chunks-1) {
|
||||
int size = vb2_plane_size(&buf->vb, 0);
|
||||
int size = vb2_plane_size(&buf->vb.vb2_buf, 0);
|
||||
enum vb2_buffer_state state = usbtv->chunks_done ==
|
||||
usbtv->n_chunks ?
|
||||
VB2_BUF_STATE_DONE :
|
||||
VB2_BUF_STATE_ERROR;
|
||||
|
||||
buf->vb.v4l2_buf.field = V4L2_FIELD_INTERLACED;
|
||||
buf->vb.v4l2_buf.sequence = usbtv->sequence++;
|
||||
v4l2_get_timestamp(&buf->vb.v4l2_buf.timestamp);
|
||||
vb2_set_plane_payload(&buf->vb, 0, size);
|
||||
vb2_buffer_done(&buf->vb, state);
|
||||
buf->vb.field = V4L2_FIELD_INTERLACED;
|
||||
buf->vb.sequence = usbtv->sequence++;
|
||||
v4l2_get_timestamp(&buf->vb.timestamp);
|
||||
vb2_set_plane_payload(&buf->vb.vb2_buf, 0, size);
|
||||
vb2_buffer_done(&buf->vb.vb2_buf, state);
|
||||
list_del(&buf->list);
|
||||
}
|
||||
|
||||
@@ -422,7 +422,7 @@ static void usbtv_stop(struct usbtv *usbtv)
|
||||
while (!list_empty(&usbtv->bufs)) {
|
||||
struct usbtv_buf *buf = list_first_entry(&usbtv->bufs,
|
||||
struct usbtv_buf, list);
|
||||
vb2_buffer_done(&buf->vb, VB2_BUF_STATE_ERROR);
|
||||
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
|
||||
list_del(&buf->list);
|
||||
}
|
||||
spin_unlock_irqrestore(&usbtv->buflock, flags);
|
||||
@@ -617,8 +617,9 @@ static int usbtv_queue_setup(struct vb2_queue *vq,
|
||||
|
||||
static void usbtv_buf_queue(struct vb2_buffer *vb)
|
||||
{
|
||||
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
||||
struct usbtv *usbtv = vb2_get_drv_priv(vb->vb2_queue);
|
||||
struct usbtv_buf *buf = container_of(vb, struct usbtv_buf, vb);
|
||||
struct usbtv_buf *buf = container_of(vbuf, struct usbtv_buf, vb);
|
||||
unsigned long flags;
|
||||
|
||||
if (usbtv->udev == NULL) {
|
||||
|
@@ -24,6 +24,7 @@
|
||||
#include <linux/usb.h>
|
||||
|
||||
#include <media/v4l2-device.h>
|
||||
#include <media/videobuf2-v4l2.h>
|
||||
#include <media/videobuf2-vmalloc.h>
|
||||
|
||||
/* Hardware. */
|
||||
@@ -61,7 +62,7 @@ struct usbtv_norm_params {
|
||||
|
||||
/* A single videobuf2 frame buffer. */
|
||||
struct usbtv_buf {
|
||||
struct vb2_buffer vb;
|
||||
struct vb2_v4l2_buffer vb;
|
||||
struct list_head list;
|
||||
};
|
||||
|
||||
|
在新工单中引用
屏蔽一个用户