[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer. Add new member variables - bytesused, length, offset, userptr, fd, data_offset - to struct vb2_plane in order to cover all information of v4l2_plane. struct vb2_plane { <snip> unsigned int bytesused; unsigned int length; union { unsigned int offset; unsigned long userptr; int fd; } m; unsigned int data_offset; } Replace v4l2_buf with new member variables - index, type, memory - which are common fields for buffer management. struct vb2_buffer { <snip> unsigned int index; unsigned int type; unsigned int memory; unsigned int num_planes; struct vb2_plane planes[VIDEO_MAX_PLANES]; <snip> }; v4l2 specific fields - flags, field, timestamp, timecode, sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c struct vb2_v4l2_buffer { struct vb2_buffer vb2_buf; __u32 flags; __u32 field; struct timeval timestamp; struct v4l2_timecode timecode; __u32 sequence; }; Signed-off-by: Junghak Sung <jh1009.sung@samsung.com> Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> Acked-by: Inki Dae <inki.dae@samsung.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:

committed by
Mauro Carvalho Chehab

parent
c139990e84
commit
2d7007153f
@@ -28,6 +28,7 @@
|
||||
#include <media/v4l2-ctrls.h>
|
||||
#include <media/v4l2-event.h>
|
||||
#include <linux/usb.h>
|
||||
#include <media/videobuf2-v4l2.h>
|
||||
#include <media/videobuf2-vmalloc.h>
|
||||
#include <linux/spi/spi.h>
|
||||
|
||||
@@ -112,7 +113,8 @@ static const unsigned int NUM_FORMATS = ARRAY_SIZE(formats);
|
||||
|
||||
/* intermediate buffers with raw data from the USB device */
|
||||
struct msi2500_frame_buf {
|
||||
struct vb2_buffer vb; /* common v4l buffer stuff -- must be first */
|
||||
/* common v4l buffer stuff -- must be first */
|
||||
struct vb2_v4l2_buffer vb;
|
||||
struct list_head list;
|
||||
};
|
||||
|
||||
@@ -431,10 +433,10 @@ static void msi2500_isoc_handler(struct urb *urb)
|
||||
}
|
||||
|
||||
/* fill framebuffer */
|
||||
ptr = vb2_plane_vaddr(&fbuf->vb, 0);
|
||||
ptr = vb2_plane_vaddr(&fbuf->vb.vb2_buf, 0);
|
||||
flen = msi2500_convert_stream(dev, ptr, iso_buf, flen);
|
||||
vb2_set_plane_payload(&fbuf->vb, 0, flen);
|
||||
vb2_buffer_done(&fbuf->vb, VB2_BUF_STATE_DONE);
|
||||
vb2_set_plane_payload(&fbuf->vb.vb2_buf, 0, flen);
|
||||
vb2_buffer_done(&fbuf->vb.vb2_buf, VB2_BUF_STATE_DONE);
|
||||
}
|
||||
|
||||
handler_end:
|
||||
@@ -569,7 +571,7 @@ static void msi2500_cleanup_queued_bufs(struct msi2500_dev *dev)
|
||||
buf = list_entry(dev->queued_bufs.next,
|
||||
struct msi2500_frame_buf, list);
|
||||
list_del(&buf->list);
|
||||
vb2_buffer_done(&buf->vb, VB2_BUF_STATE_ERROR);
|
||||
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
|
||||
}
|
||||
spin_unlock_irqrestore(&dev->queued_bufs_lock, flags);
|
||||
}
|
||||
@@ -633,15 +635,16 @@ static int msi2500_queue_setup(struct vb2_queue *vq,
|
||||
|
||||
static void msi2500_buf_queue(struct vb2_buffer *vb)
|
||||
{
|
||||
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
||||
struct msi2500_dev *dev = vb2_get_drv_priv(vb->vb2_queue);
|
||||
struct msi2500_frame_buf *buf = container_of(vb,
|
||||
struct msi2500_frame_buf *buf = container_of(vbuf,
|
||||
struct msi2500_frame_buf,
|
||||
vb);
|
||||
unsigned long flags;
|
||||
|
||||
/* Check the device has not disconnected between prep and queuing */
|
||||
if (unlikely(!dev->udev)) {
|
||||
vb2_buffer_done(&buf->vb, VB2_BUF_STATE_ERROR);
|
||||
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
|
||||
return;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user