[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer. Add new member variables - bytesused, length, offset, userptr, fd, data_offset - to struct vb2_plane in order to cover all information of v4l2_plane. struct vb2_plane { <snip> unsigned int bytesused; unsigned int length; union { unsigned int offset; unsigned long userptr; int fd; } m; unsigned int data_offset; } Replace v4l2_buf with new member variables - index, type, memory - which are common fields for buffer management. struct vb2_buffer { <snip> unsigned int index; unsigned int type; unsigned int memory; unsigned int num_planes; struct vb2_plane planes[VIDEO_MAX_PLANES]; <snip> }; v4l2 specific fields - flags, field, timestamp, timecode, sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c struct vb2_v4l2_buffer { struct vb2_buffer vb2_buf; __u32 flags; __u32 field; struct timeval timestamp; struct v4l2_timecode timecode; __u32 sequence; }; Signed-off-by: Junghak Sung <jh1009.sung@samsung.com> Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> Acked-by: Inki Dae <inki.dae@samsung.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:

committed by
Mauro Carvalho Chehab

vanhempi
c139990e84
commit
2d7007153f
@@ -307,7 +307,8 @@ static inline struct vpfe_device *to_vpfe(struct vpfe_ccdc *ccdc)
|
||||
return container_of(ccdc, struct vpfe_device, ccdc);
|
||||
}
|
||||
|
||||
static inline struct vpfe_cap_buffer *to_vpfe_buffer(struct vb2_buffer *vb)
|
||||
static inline
|
||||
struct vpfe_cap_buffer *to_vpfe_buffer(struct vb2_v4l2_buffer *vb)
|
||||
{
|
||||
return container_of(vb, struct vpfe_cap_buffer, vb);
|
||||
}
|
||||
@@ -1257,14 +1258,14 @@ static inline void vpfe_schedule_next_buffer(struct vpfe_device *vpfe)
|
||||
list_del(&vpfe->next_frm->list);
|
||||
|
||||
vpfe_set_sdr_addr(&vpfe->ccdc,
|
||||
vb2_dma_contig_plane_dma_addr(&vpfe->next_frm->vb, 0));
|
||||
vb2_dma_contig_plane_dma_addr(&vpfe->next_frm->vb.vb2_buf, 0));
|
||||
}
|
||||
|
||||
static inline void vpfe_schedule_bottom_field(struct vpfe_device *vpfe)
|
||||
{
|
||||
unsigned long addr;
|
||||
|
||||
addr = vb2_dma_contig_plane_dma_addr(&vpfe->next_frm->vb, 0) +
|
||||
addr = vb2_dma_contig_plane_dma_addr(&vpfe->next_frm->vb.vb2_buf, 0) +
|
||||
vpfe->field_off;
|
||||
|
||||
vpfe_set_sdr_addr(&vpfe->ccdc, addr);
|
||||
@@ -1280,10 +1281,10 @@ static inline void vpfe_schedule_bottom_field(struct vpfe_device *vpfe)
|
||||
*/
|
||||
static inline void vpfe_process_buffer_complete(struct vpfe_device *vpfe)
|
||||
{
|
||||
v4l2_get_timestamp(&vpfe->cur_frm->vb.v4l2_buf.timestamp);
|
||||
vpfe->cur_frm->vb.v4l2_buf.field = vpfe->fmt.fmt.pix.field;
|
||||
vpfe->cur_frm->vb.v4l2_buf.sequence = vpfe->sequence++;
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb, VB2_BUF_STATE_DONE);
|
||||
v4l2_get_timestamp(&vpfe->cur_frm->vb.timestamp);
|
||||
vpfe->cur_frm->vb.field = vpfe->fmt.fmt.pix.field;
|
||||
vpfe->cur_frm->vb.sequence = vpfe->sequence++;
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb.vb2_buf, VB2_BUF_STATE_DONE);
|
||||
vpfe->cur_frm = vpfe->next_frm;
|
||||
}
|
||||
|
||||
@@ -1942,6 +1943,7 @@ static int vpfe_queue_setup(struct vb2_queue *vq,
|
||||
*/
|
||||
static int vpfe_buffer_prepare(struct vb2_buffer *vb)
|
||||
{
|
||||
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
||||
struct vpfe_device *vpfe = vb2_get_drv_priv(vb->vb2_queue);
|
||||
|
||||
vb2_set_plane_payload(vb, 0, vpfe->fmt.fmt.pix.sizeimage);
|
||||
@@ -1949,7 +1951,7 @@ static int vpfe_buffer_prepare(struct vb2_buffer *vb)
|
||||
if (vb2_get_plane_payload(vb, 0) > vb2_plane_size(vb, 0))
|
||||
return -EINVAL;
|
||||
|
||||
vb->v4l2_buf.field = vpfe->fmt.fmt.pix.field;
|
||||
vbuf->field = vpfe->fmt.fmt.pix.field;
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -1960,8 +1962,9 @@ static int vpfe_buffer_prepare(struct vb2_buffer *vb)
|
||||
*/
|
||||
static void vpfe_buffer_queue(struct vb2_buffer *vb)
|
||||
{
|
||||
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
||||
struct vpfe_device *vpfe = vb2_get_drv_priv(vb->vb2_queue);
|
||||
struct vpfe_cap_buffer *buf = to_vpfe_buffer(vb);
|
||||
struct vpfe_cap_buffer *buf = to_vpfe_buffer(vbuf);
|
||||
unsigned long flags = 0;
|
||||
|
||||
/* add the buffer to the DMA queue */
|
||||
@@ -2006,7 +2009,7 @@ static int vpfe_start_streaming(struct vb2_queue *vq, unsigned int count)
|
||||
list_del(&vpfe->cur_frm->list);
|
||||
spin_unlock_irqrestore(&vpfe->dma_queue_lock, flags);
|
||||
|
||||
addr = vb2_dma_contig_plane_dma_addr(&vpfe->cur_frm->vb, 0);
|
||||
addr = vb2_dma_contig_plane_dma_addr(&vpfe->cur_frm->vb.vb2_buf, 0);
|
||||
|
||||
vpfe_set_sdr_addr(&vpfe->ccdc, (unsigned long)(addr));
|
||||
|
||||
@@ -2023,7 +2026,7 @@ static int vpfe_start_streaming(struct vb2_queue *vq, unsigned int count)
|
||||
err:
|
||||
list_for_each_entry_safe(buf, tmp, &vpfe->dma_queue, list) {
|
||||
list_del(&buf->list);
|
||||
vb2_buffer_done(&buf->vb, VB2_BUF_STATE_QUEUED);
|
||||
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_QUEUED);
|
||||
}
|
||||
|
||||
return ret;
|
||||
@@ -2055,13 +2058,14 @@ static void vpfe_stop_streaming(struct vb2_queue *vq)
|
||||
/* release all active buffers */
|
||||
spin_lock_irqsave(&vpfe->dma_queue_lock, flags);
|
||||
if (vpfe->cur_frm == vpfe->next_frm) {
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb, VB2_BUF_STATE_ERROR);
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb.vb2_buf,
|
||||
VB2_BUF_STATE_ERROR);
|
||||
} else {
|
||||
if (vpfe->cur_frm != NULL)
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb,
|
||||
vb2_buffer_done(&vpfe->cur_frm->vb.vb2_buf,
|
||||
VB2_BUF_STATE_ERROR);
|
||||
if (vpfe->next_frm != NULL)
|
||||
vb2_buffer_done(&vpfe->next_frm->vb,
|
||||
vb2_buffer_done(&vpfe->next_frm->vb.vb2_buf,
|
||||
VB2_BUF_STATE_ERROR);
|
||||
}
|
||||
|
||||
@@ -2069,7 +2073,8 @@ static void vpfe_stop_streaming(struct vb2_queue *vq)
|
||||
vpfe->next_frm = list_entry(vpfe->dma_queue.next,
|
||||
struct vpfe_cap_buffer, list);
|
||||
list_del(&vpfe->next_frm->list);
|
||||
vb2_buffer_done(&vpfe->next_frm->vb, VB2_BUF_STATE_ERROR);
|
||||
vb2_buffer_done(&vpfe->next_frm->vb.vb2_buf,
|
||||
VB2_BUF_STATE_ERROR);
|
||||
}
|
||||
spin_unlock_irqrestore(&vpfe->dma_queue_lock, flags);
|
||||
}
|
||||
|
Viittaa uudesa ongelmassa
Block a user