xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: platform: mediatek: vpu: fix NULL ptr dereference

Browse Source 
[ Upstream commit 3df55cd773e8603b623425cc97b05e542854ad27 ]

If pdev is NULL, then it is still dereferenced.

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Hans Verkuil
2023-05-24 13:11:47 +01:00
committed by Greg Kroah-Hartman
parent 99d6afa19d
commit 2caeb722f0
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/platform/mtk-vpu/mtk_vpu.c
View File

@@ -539,15 +539,17 @@ static int load_requested_vpu(struct mtk_vpu *vpu,
int vpu_load_firmware(struct platform_device *pdev) int vpu_load_firmware(struct platform_device *pdev)
{ {
struct mtk_vpu *vpu; struct mtk_vpu *vpu;
struct device *dev = &pdev->dev; struct device *dev;
struct vpu_run *run; struct vpu_run *run;
int ret; int ret;
if (!pdev) { if (!pdev) {
dev_err(dev, "VPU platform device is invalid\n"); pr_err("VPU platform device is invalid\n");
return -EINVAL; return -EINVAL;
} }
dev = &pdev->dev;
vpu = platform_get_drvdata(pdev); vpu = platform_get_drvdata(pdev);
run = &vpu->run; run = &vpu->run;