nilfs2: Convert to new freezing mechanism
We change nilfs_page_mkwrite() to provide proper freeze protection for writeable page faults (we must wait for frozen filesystem even if the page is fully mapped). We remove all vfs_check_frozen() checks since they are now handled by the generic code. CC: linux-nilfs@vger.kernel.org CC: KONISHI Ryusuke <konishi.ryusuke@lab.ntt.co.jp> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
@@ -69,16 +69,18 @@ static int nilfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
|
||||
struct page *page = vmf->page;
|
||||
struct inode *inode = vma->vm_file->f_dentry->d_inode;
|
||||
struct nilfs_transaction_info ti;
|
||||
int ret;
|
||||
int ret = 0;
|
||||
|
||||
if (unlikely(nilfs_near_disk_full(inode->i_sb->s_fs_info)))
|
||||
return VM_FAULT_SIGBUS; /* -ENOSPC */
|
||||
|
||||
sb_start_pagefault(inode->i_sb);
|
||||
lock_page(page);
|
||||
if (page->mapping != inode->i_mapping ||
|
||||
page_offset(page) >= i_size_read(inode) || !PageUptodate(page)) {
|
||||
unlock_page(page);
|
||||
return VM_FAULT_NOPAGE; /* make the VM retry the fault */
|
||||
ret = -EFAULT; /* make the VM retry the fault */
|
||||
goto out;
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -112,19 +114,21 @@ static int nilfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
|
||||
ret = nilfs_transaction_begin(inode->i_sb, &ti, 1);
|
||||
/* never returns -ENOMEM, but may return -ENOSPC */
|
||||
if (unlikely(ret))
|
||||
return VM_FAULT_SIGBUS;
|
||||
goto out;
|
||||
|
||||
ret = block_page_mkwrite(vma, vmf, nilfs_get_block);
|
||||
if (ret != VM_FAULT_LOCKED) {
|
||||
ret = __block_page_mkwrite(vma, vmf, nilfs_get_block);
|
||||
if (ret) {
|
||||
nilfs_transaction_abort(inode->i_sb);
|
||||
return ret;
|
||||
goto out;
|
||||
}
|
||||
nilfs_set_file_dirty(inode, 1 << (PAGE_SHIFT - inode->i_blkbits));
|
||||
nilfs_transaction_commit(inode->i_sb);
|
||||
|
||||
mapped:
|
||||
wait_on_page_writeback(page);
|
||||
return VM_FAULT_LOCKED;
|
||||
out:
|
||||
sb_end_pagefault(inode->i_sb);
|
||||
return block_page_mkwrite_return(ret);
|
||||
}
|
||||
|
||||
static const struct vm_operations_struct nilfs_file_vm_ops = {
|
||||
|
Reference in New Issue
Block a user