xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Staging: ipack/devices/ipoctal: Check tty_register_device return value.

Browse Source 
Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jens Taprogge
2012-09-12 14:55:40 +02:00
committed by Greg Kroah-Hartman
parent 1adda49706
commit 2afb41d9d3
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/ipack/devices/ipoctal.c
View File

@@ -437,6 +437,8 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
ipoctal->tty_drv = tty; ipoctal->tty_drv = tty;
for (i = 0; i < NR_CHANNELS; i++) { for (i = 0; i < NR_CHANNELS; i++) {
struct device *tty_dev;
channel = &ipoctal->channel[i]; channel = &ipoctal->channel[i];
tty_port_init(&channel->tty_port); tty_port_init(&channel->tty_port);
tty_port_alloc_xmit_buf(&channel->tty_port); tty_port_alloc_xmit_buf(&channel->tty_port);
@@ -450,7 +452,11 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
channel->pointer_read = 0; channel->pointer_read = 0;
channel->pointer_write = 0; channel->pointer_write = 0;
channel->nb_bytes = 0; channel->nb_bytes = 0;
tty_register_device(tty, i, NULL); tty_dev = tty_register_device(tty, i, NULL);
if (IS_ERR(tty_dev)) {
dev_err(&ipoctal->dev->dev, "Failed to register tty device.\n");
continue;
}
/* /*
* Enable again the RX. TX will be enabled when * Enable again the RX. TX will be enabled when