ext4: Clean up ext4_get_blocks() so it does not depend on bh_result->b_state
The ext4_get_blocks() function was depending on the value of bh_result->b_state as an input parameter to decide whether or not update the delalloc accounting statistics by calling ext4_da_update_reserve_space(). We now use a separate flag, EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE, to requests this update, so that all callers of ext4_get_blocks() can clear map_bh.b_state before calling ext4_get_blocks() without worrying about any consistency issues. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
@@ -318,16 +318,21 @@ struct ext4_new_group_data {
|
||||
*/
|
||||
/* Allocate any needed blocks and/or convert an unitialized
|
||||
extent to be an initialized ext4 */
|
||||
#define EXT4_GET_BLOCKS_CREATE 1
|
||||
#define EXT4_GET_BLOCKS_CREATE 0x0001
|
||||
/* Request the creation of an unitialized extent */
|
||||
#define EXT4_GET_BLOCKS_UNINIT_EXT 2
|
||||
#define EXT4_GET_BLOCKS_UNINIT_EXT 0x0002
|
||||
#define EXT4_GET_BLOCKS_CREATE_UNINIT_EXT (EXT4_GET_BLOCKS_UNINIT_EXT|\
|
||||
EXT4_GET_BLOCKS_CREATE)
|
||||
/* Update the ext4_inode_info i_disksize field */
|
||||
#define EXT4_GET_BLOCKS_EXTEND_DISKSIZE 4
|
||||
#define EXT4_GET_BLOCKS_EXTEND_DISKSIZE 0x0004
|
||||
/* Caller is from the delayed allocation writeout path,
|
||||
so the filesystem blocks have already been accounted for */
|
||||
#define EXT4_GET_BLOCKS_DELALLOC_RESERVE 8
|
||||
so set the magic i_delalloc_reserve_flag after taking the
|
||||
inode allocation semaphore for */
|
||||
#define EXT4_GET_BLOCKS_DELALLOC_RESERVE 0x0008
|
||||
/* Call ext4_da_update_reserve_space() after successfully
|
||||
allocating the blocks */
|
||||
#define EXT4_GET_BLOCKS_UPDATE_RESERVE_SPACE 0x0010
|
||||
|
||||
|
||||
/*
|
||||
* ioctl commands
|
||||
|
Reference in New Issue
Block a user