Merge tag 'usb-4.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
Pull USB updates from Greg KH: "Here's the big USB patchset for 4.2-rc1. As is normal these days, the majority of changes are in the gadget drivers, with a bunch of other small driver changes. All of these have been in linux-next with no reported issues" * tag 'usb-4.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (175 commits) usb: dwc3: Use ASCII space in Kconfig usb: chipidea: add work-around for Marvell HSIC PHY startup usb: chipidea: allow multiple instances to use default ci_default_pdata dt-bindings: Consolidate ChipIdea USB ci13xxx bindings phy: add Marvell HSIC 28nm PHY phy: Add Marvell USB 2.0 OTG 28nm PHY dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings USB: ssb: use devm_kzalloc USB: ssb: fix error handling in ssb_hcd_create_pdev() usb: isp1760: check for null return from kzalloc cdc-acm: Add support of ATOL FPrint fiscal printers usb: chipidea: usbmisc_imx: Remove unneeded semicolon USB: usbtmc: add device quirk for Rigol DS6104 USB: serial: mos7840: Use setup_timer phy: twl4030-usb: add ABI documentation phy: twl4030-usb: remove incorrect pm_runtime_get_sync() in probe function. phy: twl4030-usb: remove pointless 'suspended' test in 'suspend' callback. phy: twl4030-usb: make runtime pm more reliable. drivers:usb:fsl: Fix compilation error for fsl ehci drv usb: renesas_usbhs: Don't disable the pipe if Control write status stage ...
This commit is contained in:
@@ -2316,10 +2316,12 @@ sisusb_reset_text_mode(struct sisusb_usb_data *sisusb, int init)
|
||||
/* Set mode 0x03 */
|
||||
SiSUSBSetMode(sisusb->SiS_Pr, 0x03);
|
||||
|
||||
if (!(myfont = find_font("VGA8x16")))
|
||||
myfont = find_font("VGA8x16");
|
||||
if (!myfont)
|
||||
return 1;
|
||||
|
||||
if (!(tempbuf = vmalloc(8192)))
|
||||
tempbuf = vmalloc(8192);
|
||||
if (!tempbuf)
|
||||
return 1;
|
||||
|
||||
for (i = 0; i < 256; i++)
|
||||
@@ -2342,7 +2344,8 @@ sisusb_reset_text_mode(struct sisusb_usb_data *sisusb, int init)
|
||||
|
||||
if (init && !sisusb->scrbuf) {
|
||||
|
||||
if ((tempbuf = vmalloc(8192))) {
|
||||
tempbuf = vmalloc(8192);
|
||||
if (tempbuf) {
|
||||
|
||||
i = 4096;
|
||||
tempbufb = (u16 *)tempbuf;
|
||||
@@ -2417,11 +2420,13 @@ sisusb_open(struct inode *inode, struct file *file)
|
||||
struct usb_interface *interface;
|
||||
int subminor = iminor(inode);
|
||||
|
||||
if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
|
||||
interface = usb_find_interface(&sisusb_driver, subminor);
|
||||
if (!interface) {
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
if (!(sisusb = usb_get_intfdata(interface))) {
|
||||
sisusb = usb_get_intfdata(interface);
|
||||
if (!sisusb) {
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
@@ -2488,7 +2493,8 @@ sisusb_release(struct inode *inode, struct file *file)
|
||||
{
|
||||
struct sisusb_usb_data *sisusb;
|
||||
|
||||
if (!(sisusb = file->private_data))
|
||||
sisusb = file->private_data;
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -2520,7 +2526,8 @@ sisusb_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos)
|
||||
u16 buf16;
|
||||
u32 buf32, address;
|
||||
|
||||
if (!(sisusb = file->private_data))
|
||||
sisusb = file->private_data;
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -2662,7 +2669,8 @@ sisusb_write(struct file *file, const char __user *buffer, size_t count,
|
||||
u16 buf16;
|
||||
u32 buf32, address;
|
||||
|
||||
if (!(sisusb = file->private_data))
|
||||
sisusb = file->private_data;
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -2805,7 +2813,8 @@ sisusb_lseek(struct file *file, loff_t offset, int orig)
|
||||
struct sisusb_usb_data *sisusb;
|
||||
loff_t ret;
|
||||
|
||||
if (!(sisusb = file->private_data))
|
||||
sisusb = file->private_data;
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -2970,7 +2979,8 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
||||
long retval = 0;
|
||||
u32 __user *argp = (u32 __user *)arg;
|
||||
|
||||
if (!(sisusb = file->private_data))
|
||||
sisusb = file->private_data;
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -3084,7 +3094,8 @@ static int sisusb_probe(struct usb_interface *intf,
|
||||
dev->devnum);
|
||||
|
||||
/* Allocate memory for our private */
|
||||
if (!(sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL))) {
|
||||
sisusb = kzalloc(sizeof(*sisusb), GFP_KERNEL);
|
||||
if (!sisusb) {
|
||||
dev_err(&dev->dev, "Failed to allocate memory for private data\n");
|
||||
return -ENOMEM;
|
||||
}
|
||||
@@ -3093,7 +3104,8 @@ static int sisusb_probe(struct usb_interface *intf,
|
||||
mutex_init(&(sisusb->lock));
|
||||
|
||||
/* Register device */
|
||||
if ((retval = usb_register_dev(intf, &usb_sisusb_class))) {
|
||||
retval = usb_register_dev(intf, &usb_sisusb_class);
|
||||
if (retval) {
|
||||
dev_err(&sisusb->sisusb_dev->dev, "Failed to get a minor for device %d\n",
|
||||
dev->devnum);
|
||||
retval = -ENODEV;
|
||||
@@ -3214,7 +3226,8 @@ static void sisusb_disconnect(struct usb_interface *intf)
|
||||
struct sisusb_usb_data *sisusb;
|
||||
|
||||
/* This should *not* happen */
|
||||
if (!(sisusb = usb_get_intfdata(intf)))
|
||||
sisusb = usb_get_intfdata(intf);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
#ifdef INCL_SISUSB_CON
|
||||
|
@@ -169,7 +169,8 @@ sisusb_get_sisusb_lock_and_check(unsigned short console)
|
||||
if (in_atomic())
|
||||
return NULL;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb(console)))
|
||||
sisusb = sisusb_get_sisusb(console);
|
||||
if (!sisusb)
|
||||
return NULL;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -214,7 +215,8 @@ sisusbcon_init(struct vc_data *c, int init)
|
||||
* are set up/restored.
|
||||
*/
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -277,7 +279,8 @@ sisusbcon_deinit(struct vc_data *c)
|
||||
* and others, ie not under our control.
|
||||
*/
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
mutex_lock(&sisusb->lock);
|
||||
@@ -369,7 +372,8 @@ sisusbcon_putc(struct vc_data *c, int ch, int y, int x)
|
||||
struct sisusb_usb_data *sisusb;
|
||||
ssize_t written;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -395,7 +399,8 @@ sisusbcon_putcs(struct vc_data *c, const unsigned short *s,
|
||||
u16 *dest;
|
||||
int i;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -433,7 +438,8 @@ sisusbcon_clear(struct vc_data *c, int y, int x, int height, int width)
|
||||
if (width <= 0 || height <= 0)
|
||||
return;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -486,7 +492,8 @@ sisusbcon_bmove(struct vc_data *c, int sy, int sx,
|
||||
if (width <= 0 || height <= 0)
|
||||
return;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -520,7 +527,8 @@ sisusbcon_switch(struct vc_data *c)
|
||||
* Returnvalue != 0 naturally means the opposite.
|
||||
*/
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return 0;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -569,7 +577,8 @@ sisusbcon_save_screen(struct vc_data *c)
|
||||
* buffer.
|
||||
*/
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -602,7 +611,8 @@ sisusbcon_set_palette(struct vc_data *c, unsigned char *table)
|
||||
if (!CON_IS_VISIBLE(c))
|
||||
return -EINVAL;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return -EINVAL;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -637,7 +647,8 @@ sisusbcon_blank(struct vc_data *c, int blank, int mode_switch)
|
||||
ssize_t written;
|
||||
int ret = 0;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return 0;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -721,7 +732,8 @@ sisusbcon_scrolldelta(struct vc_data *c, int lines)
|
||||
|
||||
/* The return value does not seem to be used */
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return 0;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -779,7 +791,8 @@ sisusbcon_cursor(struct vc_data *c, int mode)
|
||||
struct sisusb_usb_data *sisusb;
|
||||
int from, to, baseline;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -906,7 +919,8 @@ sisusbcon_scroll(struct vc_data *c, int t, int b, int dir, int lines)
|
||||
if (!lines)
|
||||
return 1;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return 0;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -1018,7 +1032,8 @@ sisusbcon_set_origin(struct vc_data *c)
|
||||
* screenbuffer as the origin.
|
||||
*/
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return 0;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -1047,7 +1062,8 @@ sisusbcon_resize(struct vc_data *c, unsigned int newcols, unsigned int newrows,
|
||||
struct sisusb_usb_data *sisusb;
|
||||
int fh;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
fh = sisusb->current_font_height;
|
||||
@@ -1286,7 +1302,8 @@ sisusbcon_font_set(struct vc_data *c, struct console_font *font,
|
||||
if (font->width != 8 || (charcount != 256 && charcount != 512))
|
||||
return -EINVAL;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
@@ -1326,7 +1343,8 @@ sisusbcon_font_get(struct vc_data *c, struct console_font *font)
|
||||
{
|
||||
struct sisusb_usb_data *sisusb;
|
||||
|
||||
if (!(sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num)))
|
||||
sisusb = sisusb_get_sisusb_lock_and_check(c->vc_num);
|
||||
if (!sisusb)
|
||||
return -ENODEV;
|
||||
|
||||
/* sisusb->lock is down */
|
||||
|
@@ -714,7 +714,8 @@ static int uss720_probe(struct usb_interface *intf,
|
||||
/*
|
||||
* Allocate parport interface
|
||||
*/
|
||||
if (!(priv = kzalloc(sizeof(struct parport_uss720_private), GFP_KERNEL))) {
|
||||
priv = kzalloc(sizeof(struct parport_uss720_private), GFP_KERNEL);
|
||||
if (!priv) {
|
||||
usb_put_dev(usbdev);
|
||||
return -ENOMEM;
|
||||
}
|
||||
@@ -723,7 +724,8 @@ static int uss720_probe(struct usb_interface *intf,
|
||||
kref_init(&priv->ref_count);
|
||||
spin_lock_init(&priv->asynclock);
|
||||
INIT_LIST_HEAD(&priv->asynclist);
|
||||
if (!(pp = parport_register_port(0, PARPORT_IRQ_NONE, PARPORT_DMA_NONE, &parport_uss720_ops))) {
|
||||
pp = parport_register_port(0, PARPORT_IRQ_NONE, PARPORT_DMA_NONE, &parport_uss720_ops);
|
||||
if (!pp) {
|
||||
printk(KERN_WARNING "uss720: could not register parport\n");
|
||||
goto probe_abort;
|
||||
}
|
||||
|
Reference in New Issue
Block a user