NFS: Create a submount rpc_op
This simplifies the code for v2 and v3 and gives v4 a chance to decide on referrals without needing to modify the generic client. Signed-off-by: Bryan Schumaker <bjschuma@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:

committed by
Trond Myklebust

parent
2671bfc3be
commit
281cad46b3
@@ -26,11 +26,6 @@ static LIST_HEAD(nfs_automount_list);
|
||||
static DECLARE_DELAYED_WORK(nfs_automount_task, nfs_expire_automounts);
|
||||
int nfs_mountpoint_expiry_timeout = 500 * HZ;
|
||||
|
||||
static struct vfsmount *nfs_do_submount(struct dentry *dentry,
|
||||
struct nfs_fh *fh,
|
||||
struct nfs_fattr *fattr,
|
||||
rpc_authflavor_t authflavor);
|
||||
|
||||
/*
|
||||
* nfs_path - reconstruct the path given an arbitrary dentry
|
||||
* @base - used to return pointer to the end of devname part of path
|
||||
@@ -118,35 +113,6 @@ Elong:
|
||||
return ERR_PTR(-ENAMETOOLONG);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_NFS_V4
|
||||
static struct rpc_clnt *nfs_lookup_mountpoint(struct inode *dir,
|
||||
struct qstr *name,
|
||||
struct nfs_fh *fh,
|
||||
struct nfs_fattr *fattr)
|
||||
{
|
||||
int err;
|
||||
|
||||
if (NFS_PROTO(dir)->version == 4)
|
||||
return nfs4_proc_lookup_mountpoint(dir, name, fh, fattr);
|
||||
|
||||
err = NFS_PROTO(dir)->lookup(NFS_SERVER(dir)->client, dir, name, fh, fattr);
|
||||
if (err)
|
||||
return ERR_PTR(err);
|
||||
return rpc_clone_client(NFS_SERVER(dir)->client);
|
||||
}
|
||||
#else /* CONFIG_NFS_V4 */
|
||||
static inline struct rpc_clnt *nfs_lookup_mountpoint(struct inode *dir,
|
||||
struct qstr *name,
|
||||
struct nfs_fh *fh,
|
||||
struct nfs_fattr *fattr)
|
||||
{
|
||||
int err = NFS_PROTO(dir)->lookup(NFS_SERVER(dir)->client, dir, name, fh, fattr);
|
||||
if (err)
|
||||
return ERR_PTR(err);
|
||||
return rpc_clone_client(NFS_SERVER(dir)->client);
|
||||
}
|
||||
#endif /* CONFIG_NFS_V4 */
|
||||
|
||||
/*
|
||||
* nfs_d_automount - Handle crossing a mountpoint on the server
|
||||
* @path - The mountpoint
|
||||
@@ -162,10 +128,9 @@ static inline struct rpc_clnt *nfs_lookup_mountpoint(struct inode *dir,
|
||||
struct vfsmount *nfs_d_automount(struct path *path)
|
||||
{
|
||||
struct vfsmount *mnt;
|
||||
struct dentry *parent;
|
||||
struct nfs_server *server = NFS_SERVER(path->dentry->d_inode);
|
||||
struct nfs_fh *fh = NULL;
|
||||
struct nfs_fattr *fattr = NULL;
|
||||
struct rpc_clnt *client;
|
||||
|
||||
dprintk("--> nfs_d_automount()\n");
|
||||
|
||||
@@ -181,21 +146,7 @@ struct vfsmount *nfs_d_automount(struct path *path)
|
||||
|
||||
dprintk("%s: enter\n", __func__);
|
||||
|
||||
/* Look it up again to get its attributes */
|
||||
parent = dget_parent(path->dentry);
|
||||
client = nfs_lookup_mountpoint(parent->d_inode, &path->dentry->d_name, fh, fattr);
|
||||
dput(parent);
|
||||
if (IS_ERR(client)) {
|
||||
mnt = ERR_CAST(client);
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (fattr->valid & NFS_ATTR_FATTR_V4_REFERRAL)
|
||||
mnt = nfs_do_refmount(client, path->dentry);
|
||||
else
|
||||
mnt = nfs_do_submount(path->dentry, fh, fattr, client->cl_auth->au_flavor);
|
||||
rpc_shutdown_client(client);
|
||||
|
||||
mnt = server->nfs_client->rpc_ops->submount(server, path->dentry, fh, fattr);
|
||||
if (IS_ERR(mnt))
|
||||
goto out;
|
||||
|
||||
@@ -268,10 +219,8 @@ static struct vfsmount *nfs_do_clone_mount(struct nfs_server *server,
|
||||
* @authflavor - security flavor to use when performing the mount
|
||||
*
|
||||
*/
|
||||
static struct vfsmount *nfs_do_submount(struct dentry *dentry,
|
||||
struct nfs_fh *fh,
|
||||
struct nfs_fattr *fattr,
|
||||
rpc_authflavor_t authflavor)
|
||||
struct vfsmount *nfs_do_submount(struct dentry *dentry, struct nfs_fh *fh,
|
||||
struct nfs_fattr *fattr, rpc_authflavor_t authflavor)
|
||||
{
|
||||
struct nfs_clone_mount mountdata = {
|
||||
.sb = dentry->d_sb,
|
||||
@@ -304,3 +253,19 @@ out:
|
||||
dprintk("<-- nfs_do_submount() = %p\n", mnt);
|
||||
return mnt;
|
||||
}
|
||||
|
||||
struct vfsmount *nfs_submount(struct nfs_server *server, struct dentry *dentry,
|
||||
struct nfs_fh *fh, struct nfs_fattr *fattr)
|
||||
{
|
||||
int err;
|
||||
struct dentry *parent = dget_parent(dentry);
|
||||
|
||||
/* Look it up again to get its attributes */
|
||||
err = server->nfs_client->rpc_ops->lookup(server->client, parent->d_inode,
|
||||
&dentry->d_name, fh, fattr);
|
||||
dput(parent);
|
||||
if (err != 0)
|
||||
return ERR_PTR(err);
|
||||
|
||||
return nfs_do_submount(dentry, fh, fattr, server->client->cl_auth->au_flavor);
|
||||
}
|
||||
|
Reference in New Issue
Block a user